Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix rules table refresh after rule's import #144359

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Nov 1, 2022

Resolves: #136758

Summary

It fixes the problem of the rules table refresh after importing a rule.

Before:

Screen.Recording.2022-11-01.at.21.14.58.mov

After:

Screen.Recording.2022-11-01.at.21.18.10.mov

Checklist

@maximpn maximpn added release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.6.0 labels Nov 1, 2022
@maximpn maximpn self-assigned this Nov 1, 2022
@maximpn
Copy link
Contributor Author

maximpn commented Nov 2, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.6MB 9.6MB +64.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 445 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 522 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@maximpn maximpn marked this pull request as ready for review November 2, 2022 07:35
@maximpn maximpn requested review from a team as code owners November 2, 2022 07:35
@maximpn maximpn requested a review from xcrzx November 2, 2022 07:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maximpn maximpn added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Nov 2, 2022
@maximpn
Copy link
Contributor Author

maximpn commented Nov 2, 2022

@banderror @xcrzx AFAIK we have file structure changes and usage of React Query hooks since starting from 8.6 so back-porting does't look safe here. WDYT?

@banderror
Copy link
Contributor

AFAIK we have file structure changes and usage of React Query hooks since starting from 8.6 so back-porting does't look safe here. WDYT?

@maximpn ++, I guess backporting would require fixing it from scratch in 8.5, I'd not spend time on that

Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested locally, but the code changes LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Rule Management Security Solution Detection Rule Management release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Rules page does not refresh after importing a rule
6 participants