Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Rules page does not refresh after importing a rule #136758

Closed
MadameSheema opened this issue Jul 20, 2022 · 8 comments · Fixed by #144359
Closed

[Security Solution] Rules page does not refresh after importing a rule #136758

MadameSheema opened this issue Jul 20, 2022 · 8 comments · Fixed by #144359
Assignees
@maximpn
Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@MadameSheema
Copy link
Member

Describe the bug:

  • Rules page does not refresh after importing a rule. Note that this is just happening with an empty rules page

Kibana/Elasticsearch Stack version:

Initial setup:

  • A clean instance without any rule on it

Steps to reproduce:

  1. Navigate to Rules page
  2. Click on Import rules
  3. Select or drag and drop an ndjson containing a rule
  4. Click on Import

Current behavior:

  • A message informing the user that the rule has been successfully imported is displayed.
  • The rule page does not get refreshed
  • The rule is not even displayed after navigating to a different page and going back to the rules page

Expected behavior:

  • The rule page is refreshed and the rule is automatically displayed

Extra information:

  • Reporting this issue as a low priority since with a browser hard refresh the rule appears. Also because this is just happening when you don't have any rule on the Rules page. Please feel free to update the impact if you don't agree with it.
  • Although export/import rules belongs to Platform team, I'm assigning detection rules team since they were the ones adding a new refresh functionality to the Rules page.
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror
Copy link
Contributor

Yep, noticed that a few days ago too 👍

@banderror banderror added Feature:Rule Management Security Solution Detection Rule Management area and removed triage_needed labels Jul 21, 2022
@banderror banderror removed their assignment Jul 21, 2022
@peluja1012
Copy link
Contributor

I think this bug is related #137969

@banderror banderror mentioned this issue Aug 8, 2022
Closed
@banderror banderror mentioned this issue Aug 25, 2022
Closed
@maximpn maximpn mentioned this issue Nov 1, 2022
Merged
1 task
@maximpn maximpn linked a pull request Nov 1, 2022 that will close this issue
[Security Solution] Fix rules table refresh after rule's import #144359
Merged
1 task
maximpn added a commit that referenced this issue Nov 2, 2022
@maximpn
[Security Solution] Fix rules table refresh after rule's import (#144359
20d91f1 
)

**Resolves:** #136758

## Summary

It fixes the problem of the rules table refresh after importing a rule.

*Before:*

https://user-images.githubusercontent.com/3775283/199319505-e70918ec-1621-4048-92ba-0b83a5b19652.mov

*After:*

https://user-images.githubusercontent.com/3775283/199319768-3513dfc7-f9d2-4a84-a7ff-0b78dcf4795f.mov

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@banderror banderror reopened this Nov 3, 2022
@banderror banderror added the fixed label Nov 3, 2022
@banderror
Copy link
Contributor

@MadameSheema fixed in #144359 and will be released in 8.6.0

@MadameSheema
Copy link
Member Author

Thanks @banderror!! Is there any reason why is not going to be released on 8.5.1 as well?

@banderror
Copy link
Contributor

@MadameSheema It would be hard to backport because of the refactoring we did earlier in main.

@ghost
Copy link

ghost commented Nov 17, 2022

Hi @MadameSheema
We have validated this issue on the latest 8.6.0-BC1 build and observed that the issue is fixed. Please find below the testing details:

Build Details:
VERSION: 8.6.0-BC1
BUILD: 58392
COMMIT: 50a7feb

Screen-Recording:

Rules.-.Kibana.-.Google.Chrome.2022-11-17.15-15-15.mp4

Hence, we are closing this issue and marking it as QA Validated.

Thanks!

@ghost ghost closed this as completed Nov 17, 2022
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 17, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
8.6 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Fix rules table refresh after rule's import maximpn/kibana
6 participants
@peluja1012 @maximpn @jpdjere @banderror @elasticmachine @MadameSheema