Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIP] Run e2e pipeline on CI #144776

Merged
merged 3 commits into from
Nov 9, 2022
Merged

[TIP] Run e2e pipeline on CI #144776

merged 3 commits into from
Nov 9, 2022

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Nov 8, 2022

Summary

Last week, our team has dicovered that e2e tests are not executed on CI, this PR is an attempt to fix that.

Threat intel pipeline should be run whenever the threat_intelligence plugin source or related tests config has changed.

@lgestc lgestc requested review from a team as code owners November 8, 2022 07:45
@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: Protections Experience v8.6.0 labels Nov 8, 2022
maxcold
maxcold approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to add our code inside security_solution as a trigger for the tests, otherwise looks good, let's roll with it

.buildkite/scripts/pipelines/pull_request/pipeline.ts
if (
(await doAnyChangesMatch([
/^x-pack\/plugins\/threat_intelligence/,
/^x-pack\/test\/threat_intelligence_cypress/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add security_solution/public/threat_intelligence to the list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, makes sense, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we should consider adding other code paths for the things we pass from security_solution to our plugin through context

@lgestc
Copy link
Contributor Author

lgestc commented Nov 8, 2022

FYI @maxcold @PhilippeOberti So, the tests are executed now but are failing now - I am investigating it further.

@maxcold
Copy link
Contributor

maxcold commented Nov 8, 2022

@lgmys btw can you add a couple of notes about the e2e tests to our team dev docs? like what's the set up, how to find them on the CI and how to run all tests with the PR tag

spalger
spalger approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes LGTM

@lgestc
Copy link
Contributor Author

lgestc commented Nov 9, 2022

@lgmys btw can you add a couple of notes about the e2e tests to our team dev docs? like what's the set up, how to find them on the CI and how to run all tests with the PR tag

noted, will do:)

@lgestc
Copy link
Contributor Author

lgestc commented Nov 9, 2022

@lgmys btw can you add a couple of notes about the e2e tests to our team dev docs? like what's the set up, how to find them on the CI and how to run all tests with the PR tag

noted, will do:)

@maxcold updated readme with more info

maxcold
maxcold reviewed Nov 9, 2022
View reviewed changes
x-pack/plugins/threat_intelligence/README.md

`cd` into plugin root and execute `yarn cypress:open-as-ci`

### CI Execution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great summary!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1
threatIntelligence 1 0 -1
total -0

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
threatIntelligence 8 9 +1
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc merged commit f1be605 into elastic:main Nov 9, 2022
@lgestc lgestc deleted the ensure-e2e-execution branch November 9, 2022 11:51
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 9, 2022
@jloleysens
Merge branch 'main' into files-management
3572f7f 
* main:
  [Lens] Rearrange options (elastic#144891)
  [Actionable Observability] Integrate alert search bar on rule details page (elastic#144718)
  [Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view (elastic#144575)
  [Actionable Observability] Add context.alertDetailsUrl to connector template for Uptime > Monitor status & Uptime TLS rules (elastic#144740)
  [Security Solution] [Feat] Add Bulk Events to Timeline. (elastic#142737)
  [TIP] Env specific cypress config (elastic#144894)
  skip flaky suite (elastic#144885)
  [Enterprise Search] Fixes Search Index page to go blank when connection lost (elastic#144022)
  [Cloud Posture] track findings pages (elastic#144822)
  [ContentManagement] Inspector flyout (elastic#144240)
  [Cloud Posture] Dashboard Redesign - data counter cards (elastic#144565)
  [TIP] Run e2e pipeline on CI (elastic#144776)
  [Guided onboarding] Config updates for the Security guide (elastic#144844)
  Cleanup unused code for claiming tasks by id (elastic#144408)
  Ping the response-ops team whenever a new connector type is registered (elastic#144736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Protections Experience v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgestc @maxcold @kibana-ci @spalger