Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v70.2.4 #144845

Merged
merged 59 commits into from
Nov 18, 2022
Merged

Upgrade EUI to v70.2.4 #144845

merged 59 commits into from
Nov 18, 2022

Commits on Nov 14, 2022

  1. Upgrade EUI to v70.2.0

    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    26a094a View commit details
    Browse the repository at this point in the history
  2. Update i18n tokens

    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    9d0a49f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4047448 View commit details
    Browse the repository at this point in the history
  4. Address EUI TODO for selectable & horizontal EuiCards

    - reverts temporary fixes; should now be addressed in EUI itself
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    44ab049 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    902fa62 View commit details
    Browse the repository at this point in the history
  6. [EuiCodeBlock] Account for removed niche color var

    - corresponds to visColors, so convert to that util instead
    
    [refactor] while here, convert file to using native EUI `useEuiTheme` instead of referencing the Sass vars
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b052461 View commit details
    Browse the repository at this point in the history
  7. [EuiCodeBlock] Fix index management component using now-removed CSS c…

    …lasses
    
    address TODO by using component directly - EuiCodeBlock now supports JSX/nodes, albeit without syntax highlighting (not an issue since that wasn't being used here)
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    ee12916 View commit details
    Browse the repository at this point in the history
  8. [EuiFlex] Fix type issues

    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    0704e41 View commit details
    Browse the repository at this point in the history
  9. [EuiFlex] Fix removed Sass gutter variables

    - replace with basic EUI size variables
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d6351c5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c52d42e View commit details
    Browse the repository at this point in the history
  11. [EuiFlex] Fix tests assertions

    - Emotion adds another wrapper, so we now have to use `.last()` in Enzyme finding
    
    - className modifiers have been removed, so we have to replace them with their Emotion equivalents - this isn't great but to be honest we don't recommend asserting on EUI classNames anyway
    
    - certain selectors updated to specificy their raw/DOM output vs enzyme wrappers
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    4a427fe View commit details
    Browse the repository at this point in the history
  12. [EuiFlex] Snapshot updates

    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    681f989 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ef4eb55 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    237341b View commit details
    Browse the repository at this point in the history
  15. [EuiSkipLink] Fix event type

    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    212b25c View commit details
    Browse the repository at this point in the history
  16. [EuiSkipLink] Fix custom usage for table

    - prefer a similar-looking EuiButton instead of EuiSkipLink directly, since EuiSkipLink's scrolling and fallback behavior is not needed
    
    copy EuiSkipLink's minor style overrides & positioning to SCSS instead
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    03def98 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    dd64ea2 View commit details
    Browse the repository at this point in the history
  18. [EuiCard] Update snapshots

    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e6c252d View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    3e5cabc View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9fd86b5 View commit details
    Browse the repository at this point in the history
  21. [EuiTab] Fix selectors/test assertions

    Emotion wrapper is now taking the `key` from EuiTab, so we can no longer use that selector. Swtiching to data-test-subj instead of `key` fixes the issue (although it creates type shenanigans)
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d006461 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    9547e1a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    ab980d0 View commit details
    Browse the repository at this point in the history
  24. Fix multiple tests to use rendered vs mounted snapshots

    - Emotion wrappers add a TON of cruft to mounted snapshots, so we're moving away from them
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    6e48660 View commit details
    Browse the repository at this point in the history
  25. Update visual diff tolerance

    - NB: I can't figure out how to update baseline screenshots locally without making the diff even worse than just updating it. Guidance appreciated, or teams can go in later and update their baselines
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5265375 View commit details
    Browse the repository at this point in the history
  26. [FTR] Fix now-invalid selector caused by Emotion classes

    `--selected` is no longer at the end of the className list, but exists in there, so switch to `*=`
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    1f32026 View commit details
    Browse the repository at this point in the history
  27. [Security] Fix failing scroll test

    - appears to be back to 0 this upgrade for whatever reason. Changing the test to < 5 should account for any variance in overflow/scrollbars
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    d43735e View commit details
    Browse the repository at this point in the history
  28. [Security] Fix broken looking flyout tabs

    - Use `append` instead of custom flex group within `name`
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    f92bf06 View commit details
    Browse the repository at this point in the history
  29. [Security] Fix spacing above flyout tabs

    - Appears to be present in previous iterations of the flyout, but was removed recently. Opinionated change but it does need some spacing
    
    - NB: fragment is needed due to inherited `children` typing - it doesn't appear to want multiple children, despite it working fine in browser
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b3e4cc9 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    3c2e62b View commit details
    Browse the repository at this point in the history
  31. [Security] Fix hidden flyout/failing Cypress test caused by `styled-c…

    …omponents` not overriding Emotion z-index CSS
    
    - adding either !important or a single extra layer of specificity fixes the issue
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    0d293fd View commit details
    Browse the repository at this point in the history
  32. [EuiFlex] Replace removed fractions variables

    not totally sure why these were even exported
    cee-chen committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b6cca3f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Configuration menu
    Copy the full SHA
    fb6642a View commit details
    Browse the repository at this point in the history
  2. [APM][PR feedback] Fix size conversion var

    Constance committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    92786f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa16cbc View commit details
    Browse the repository at this point in the history
  4. [Security] Fix incorrect use of EuiFlexGrid

    - should be EuiFlexGroup instead if only one row is desired
    cee-chen committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2dde3c1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    93c278a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    14854a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. [Security][Cases] Fix padding previously reliant on EuiFlex margins

    + simplify CSS - these styles can be applied to the wrapper directly instead of nesting into the EuiFlexGroup
    cee-chen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6dcdf94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ca6ed5 View commit details
    Browse the repository at this point in the history
  3. [ML][DataVisualizer] Fix incorrect usage of EuiFlexGrid

    - should be EuiFlexGroup instead if 0 columns are being specified
    cee-chen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    ca332d2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    beeb9b7 View commit details
    Browse the repository at this point in the history
  5. [ML][Jobs] Fix missing margins in Jobs Groups list

    - caused by switch to `gap`
    cee-chen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    fb3056a View commit details
    Browse the repository at this point in the history
  6. Update snapshots from main

    cee-chen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    d09aab4 View commit details
    Browse the repository at this point in the history
  7. more snapshots

    cee-chen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    32b2384 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Configuration menu
    Copy the full SHA
    46cccd3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed28359 View commit details
    Browse the repository at this point in the history
  3. [EuiFlyout] snapshot updates

    - caused by overflow shadow CSS changing
    cee-chen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f8aa870 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d18cf7a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4936913 View commit details
    Browse the repository at this point in the history
  6. [Maps] snapshots

    cee-chen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    c24c836 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b6f322a View commit details
    Browse the repository at this point in the history
  8. Upgrade EUI to v70.2.4

    - To get EuiSuperDatePicker and EuiFlex fixes
    cee-chen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    12cba12 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c085c5e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0756d11 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Configuration menu
    Copy the full SHA
    759e0f8 View commit details
    Browse the repository at this point in the history
  2. [Security] EuiDescriptionList tweaks

    - per request
    cee-chen committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    d5f93d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99391c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fdcfd91 View commit details
    Browse the repository at this point in the history