Ability to create a filter from a lat/long. #144063

[desean1625]

Summary

Paste location and create a filter

PR for issue #144063

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[nickpeihl]

Thanks for your contribution! This looks like a useful feature.

Here's a video showing how this looks in this PR.

maps-goto.mp4

I'm not a big fan of the software trying to guess which coordinate system the user is pasting in the "Paste location" form. I'd rather the user specify which coordinate system they are using (they already know that, right?) and adapt the input parser accordingly.

I am concerned about the design (both current and proposed by this PR) that is using popovers within popovers. The initial design of the SetViewControl component only had the lat, lon, zoom form. We modified this a while back to allow for other coordinate systems. With this feature we are adding another option. That's a lot of features for a simple popover. I think we might want to consider changing the SetViewControl to use an EuiContextMenu component instead.

Items in an EuiContextMenu can also have nested content panels. So we could have a list of items like "Decimal degrees", "UTM", "MGRS" with each item opening a nested panel containing a form for entering the input. This would make it easier for the user to specify the coordinate system of their pasted inputs, too.

I'd love to get more input from others including @elastic/kibana-presentation and @andreadelrio.

[desean1625]

@nickpeihl You missed the paste location in the distance filter. You can paste a location and it sets the center point for a distance filter

[nickpeihl]

@nickpeihl You missed the paste location in the distance filter. You can paste a location and it sets the center point for a distance filter

Yes I did. My apologies. Here's a video in action.

distance-filter.mp4

The filter is a good example of a EuiContextMenu. I wonder if we could still have an option in that form for the user to choose the coordinate system instead of the software trying to guess?

[nreese]

My 2 cents

Users should not create filters from "set view" control. This feature should only be added under "tools" control. Feature should not be combined with "Draw distance to filter data" and instead be exposed as a new menu option as something like "Enter location to filter data". Then the form would show the location input and a distance input.

[desean1625]

@nreese In the set view control that is only setting the go-to location and panning the map it does not create the filter