Set configurable to true so AggConfig decorated properties can be deleted #14569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Visualizations
timroes
approved these changes
Oct 25, 2017
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 25, 2017
…eted (elastic#14569) * make decorated property configurable so it can be deleted * same for histogram aggregation
nreese
added a commit
that referenced
this pull request
Oct 25, 2017
…eted (#14569) * make decorated property configurable so it can be deleted * same for histogram aggregation
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
…eted (elastic#14569) * make decorated property configurable so it can be deleted * same for histogram aggregation
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
…eted (elastic#14569) * make decorated property configurable so it can be deleted * same for histogram aggregation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14457
https://stackoverflow.com/a/25518028/890809, a property created with
Object.defineProperty()can only be deleted whenconfigurable: true. Otherwise an exception is thrown