Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.6] [Security Solution] Update cache invalidation logic to handle error responses (#146271) #146380

Merged
merged 1 commit into from
Nov 28, 2022
Merged

[8.6] [Security Solution] Update cache invalidation logic to handle error responses (#146271) #146380

merged 1 commit into from
Nov 28, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.6:

Questions ?

Please refer to the Backport tool documentation

@xcrzx
[Security Solution] Update cache invalidation logic to handle error r…
ce932d0 
…esponses (#146271)

**Resolves: #146277

## Summary

Previously, we invalidated the rules table cache only after successful
server-side state mutations. So when an action like bulk edit was
successfully updating some rules and failing for others, the table
continued showing outdated results.

This PR moves the cache invalidation from the `onSuccess` handlers to
the `onSettled` handlers to prevent showing partially stale data after
failed updates.

(cherry picked from commit e9bc603)
@kibanamachine kibanamachine enabled auto-merge (squash) November 28, 2022 11:55
@kibanamachine kibanamachine mentioned this pull request Nov 28, 2022
Merged
@kibanamachine kibanamachine merged commit 8320b80 into 8.6 Nov 28, 2022
@kibanamachine kibanamachine deleted the backport/8.6/pr-146271 branch November 28, 2022 13:18
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.7MB 9.7MB +48.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 442 448 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 109 115 +6
securitySolution 519 525 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @xcrzx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xcrzx xcrzx

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kibanamachine @kibana-ci @xcrzx