Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.6] [Security Solution] Update cache invalidation logic to handle error responses (#146271) #146380

Merged
merged 1 commit into from
Nov 28, 2022
Merged

[8.6] [Security Solution] Update cache invalidation logic to handle error responses (#146271) #146380

merged 1 commit into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. [Security Solution] Update cache invalidation logic to handle error r… 

    …esponses (#146271)

**Resolves: #146277

## Summary

Previously, we invalidated the rules table cache only after successful
server-side state mutations. So when an action like bulk edit was
successfully updating some rules and failing for others, the table
continued showing outdated results.

This PR moves the cache invalidation from the `onSuccess` handlers to
the `onSettled` handlers to prevent showing partially stale data after
failed updates.

(cherry picked from commit e9bc603)
    @xcrzx
    xcrzx committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ce932d0 View commit details
    Browse the repository at this point in the history