-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Improve check for response size in /autocomplete_entities
endpoint
#148328
[Console] Improve check for response size in /autocomplete_entities
endpoint
#148328
Conversation
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @darnautov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing this @darnautov!
… endpoint (elastic#148328) (cherry picked from commit bc19656)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
8 similar comments
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…ities` endpoint (#148328) (#148401) # Backport This will backport the following commits from `main` to `8.6`: - [[Console] Improve check for response size in `/autocomplete_entities` endpoint (#148328)](#148328) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-01-04T15:48:31Z","message":"[Console] Improve check for response size in `/autocomplete_entities` endpoint (#148328)","sha":"bc19656c3c1caa4e940e51342ffb3c1e57fe4f33","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Console","Feature:Dev Tools","release_note:fix","backport:prev-minor","v8.7.0"],"number":148328,"url":"#148328 Improve check for response size in `/autocomplete_entities` endpoint (#148328)","sha":"bc19656c3c1caa4e940e51342ffb3c1e57fe4f33"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#148328 Improve check for response size in `/autocomplete_entities` endpoint (#148328)","sha":"bc19656c3c1caa4e940e51342ffb3c1e57fe4f33"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Summary
Fixes the performance issue in
/autocomplete_entities
endpoint by replacing theBuffer.concat
with accumulating bytes length on thedata
event for checking the response size.Checklist