Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Improve check for response size in /autocomplete_entities endpoint #148328

Merged
merged 1 commit into from Jan 4, 2023
Merged

[Console] Improve check for response size in /autocomplete_entities endpoint #148328

merged 1 commit into from Jan 4, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jan 3, 2023 •
edited by kibanamachine

Summary

Fixes the performance issue in /autocomplete_entities endpoint by replacing the Buffer.concat with accumulating bytes length on the data event for checking the response size.

image

Checklist

@darnautov darnautov requested a review from a team as a code owner January 3, 2023 17:04
@darnautov darnautov self-assigned this Jan 3, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@rudolf rudolf added bug Fixes for quality problems that affect the customer experience backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Jan 4, 2023
alisonelizabeth
alisonelizabeth approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this @darnautov!

@alisonelizabeth alisonelizabeth merged commit bc19656 into elastic:main Jan 4, 2023
@kibanamachine kibanamachine mentioned this pull request Jan 4, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 4, 2023
@darnautov
[Console] Improve check for response size in /autocomplete_entities…
39bf989 
… endpoint (elastic#148328)

(cherry picked from commit bc19656)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 6, 2023
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

8 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Jan 19, 2023
@kibanamachine @darnautov
[8.6] [Console] Improve check for response size in `/autocomplete_ent…
1906c49 
…ities` endpoint (#148328) (#148401)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Console] Improve check for response size in `/autocomplete_entities`
endpoint (#148328)](#148328)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-01-04T15:48:31Z","message":"[Console]
Improve check for response size in `/autocomplete_entities` endpoint
(#148328)","sha":"bc19656c3c1caa4e940e51342ffb3c1e57fe4f33","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Console","Feature:Dev
Tools","release_note:fix","backport:prev-minor","v8.7.0"],"number":148328,"url":"#148328
Improve check for response size in `/autocomplete_entities` endpoint
(#148328)","sha":"bc19656c3c1caa4e940e51342ffb3c1e57fe4f33"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#148328
Improve check for response size in `/autocomplete_entities` endpoint
(#148328)","sha":"bc19656c3c1caa4e940e51342ffb3c1e57fe4f33"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
@kibanamachine kibanamachine added v8.6.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jan 19, 2023
@darnautov darnautov deleted the console-autocomplete-suggestions-performance branch January 19, 2023 08:49
@darnautov darnautov mentioned this pull request Jan 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@jloleysens jloleysens Awaiting requested review from jloleysens

Assignees

@darnautov darnautov

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix v8.6.1 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@darnautov @kibana-ci @kibanamachine @rudolf @alisonelizabeth