Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] allow disabling throttling for project monitors #148669

Merged
merged 1 commit into from Jan 11, 2023
Merged

[Synthetics] allow disabling throttling for project monitors #148669

merged 1 commit into from Jan 11, 2023

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Jan 10, 2023 •
edited by kibanamachine

Summary

Resolves #148344

Allows for disabling throttling by adjusting the request types for project monitors

Testing

  1. Checkout the synthetics agent PR. Be sure to link the development version of the package to the your test project directory via npm link. If you don't already have a test directory, create one via npm run init.
  2. In a test project monitor, set monitor.use({ throttling: false }).
  3. Ensure no errors are reported back to the synthetics agent.
  4. In Uptime, navigate to the edit monitor page for the monitor you're testing. Scroll down to Advanced browser options. Open the accordion and confirm throttling is disabled

Screen Shot 2023-01-10 at 2 20 24 PM

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.0 labels Jan 10, 2023
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner January 10, 2023 19:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.3MB 1.3MB +21.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 04c5e65 into elastic:main Jan 11, 2023
@dominiqueclarke dominiqueclarke deleted the fix/synthetics-project-throttling-disable branch January 11, 2023 15:59
@kibanamachine kibanamachine mentioned this pull request Jan 11, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 11, 2023
@dominiqueclarke
[Synthetics] allow disabling throttling for project monitors (elastic…
9302cf7 
…#148669)

## Summary

Resolves elastic#148344

Allows for disabling throttling by adjusting the request types for
project monitors

### Testing
1. Checkout the synthetics agent PR. Be sure to link the development
version of the package to the your test project directory via `npm
link`. If you don't already have a test directory, create one via `npm
run init`.
2. In a test project monitor, set `monitor.use({ throttling: false })`.
3. Ensure no errors are reported back to the synthetics agent.
4. In Uptime, navigate to the edit monitor page for the monitor you're
testing. Scroll down to Advanced browser options. Open the accordion and
confirm throttling is disabled
<img width="1752" alt="Screen Shot 2023-01-10 at 2 20 24 PM"
src="https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png">

(cherry picked from commit 04c5e65)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 11, 2023
@kibanamachine @dominiqueclarke
[8.6] [Synthetics] allow disabling throttling for project monitors (#…
0b082e6 
…148669) (#148742)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Synthetics] allow disabling throttling for project monitors
(#148669)](#148669)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-01-11T15:59:41Z","message":"[Synthetics]
allow disabling throttling for project monitors (#148669)\n\n##
Summary\r\n\r\nResolves
#148344 for
disabling throttling by adjusting the request types for\r\nproject
monitors\r\n\r\n### Testing\r\n1. Checkout the synthetics agent PR. Be
sure to link the development\r\nversion of the package to the your test
project directory via `npm\r\nlink`. If you don't already have a test
directory, create one via `npm\r\nrun init`.\r\n2. In a test project
monitor, set `monitor.use({ throttling: false })`. \r\n3. Ensure no
errors are reported back to the synthetics agent. \r\n4. In Uptime,
navigate to the edit monitor page for the monitor you're\r\ntesting.
Scroll down to Advanced browser options. Open the accordion
and\r\nconfirm throttling is disabled\r\n<img width=\"1752\"
alt=\"Screen Shot 2023-01-10 at 2 20 24
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png\">","sha":"04c5e656e29b90d0d4e59853f2172db6e02b0b77","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:uptime","v8.7.0","v8.6.1"],"number":148669,"url":"https://github.com/elastic/kibana/pull/148669","mergeCommit":{"message":"[Synthetics]
allow disabling throttling for project monitors (#148669)\n\n##
Summary\r\n\r\nResolves
#148344 for
disabling throttling by adjusting the request types for\r\nproject
monitors\r\n\r\n### Testing\r\n1. Checkout the synthetics agent PR. Be
sure to link the development\r\nversion of the package to the your test
project directory via `npm\r\nlink`. If you don't already have a test
directory, create one via `npm\r\nrun init`.\r\n2. In a test project
monitor, set `monitor.use({ throttling: false })`. \r\n3. Ensure no
errors are reported back to the synthetics agent. \r\n4. In Uptime,
navigate to the edit monitor page for the monitor you're\r\ntesting.
Scroll down to Advanced browser options. Open the accordion
and\r\nconfirm throttling is disabled\r\n<img width=\"1752\"
alt=\"Screen Shot 2023-01-10 at 2 20 24
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png\">","sha":"04c5e656e29b90d0d4e59853f2172db6e02b0b77"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148669","number":148669,"mergeCommit":{"message":"[Synthetics]
allow disabling throttling for project monitors (#148669)\n\n##
Summary\r\n\r\nResolves
#148344 for
disabling throttling by adjusting the request types for\r\nproject
monitors\r\n\r\n### Testing\r\n1. Checkout the synthetics agent PR. Be
sure to link the development\r\nversion of the package to the your test
project directory via `npm\r\nlink`. If you don't already have a test
directory, create one via `npm\r\nrun init`.\r\n2. In a test project
monitor, set `monitor.use({ throttling: false })`. \r\n3. Ensure no
errors are reported back to the synthetics agent. \r\n4. In Uptime,
navigate to the edit monitor page for the monitor you're\r\ntesting.
Scroll down to Advanced browser options. Open the accordion
and\r\nconfirm throttling is disabled\r\n<img width=\"1752\"
alt=\"Screen Shot 2023-01-10 at 2 20 24
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png\">","sha":"04c5e656e29b90d0d4e59853f2172db6e02b0b77"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@paulb-elastic paulb-elastic mentioned this pull request Jan 11, 2023
Merged
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
@dominiqueclarke @jennypavlova
[Synthetics] allow disabling throttling for project monitors (elastic…
3f004d7 
…#148669)

## Summary

Resolves elastic#148344

Allows for disabling throttling by adjusting the request types for
project monitors

### Testing
1. Checkout the synthetics agent PR. Be sure to link the development
version of the package to the your test project directory via `npm
link`. If you don't already have a test directory, create one via `npm
run init`.
2. In a test project monitor, set `monitor.use({ throttling: false })`. 
3. Ensure no errors are reported back to the synthetics agent. 
4. In Uptime, navigate to the edit monitor page for the monitor you're
testing. Scroll down to Advanced browser options. Open the accordion and
confirm throttling is disabled
<img width="1752" alt="Screen Shot 2023-01-10 at 2 20 24 PM"
src="https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.1 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Allow project monitors to be configured with throttling disabled
5 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @shahzad31