Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow disabling throttling in project monitors #690

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Jan 3, 2023

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-03T19:30:11.332+0000

  • Duration: 15 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 2
Total 208

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshshanmugam vigneshshanmugam merged commit aedfc4b into elastic:main Jan 10, 2023
@vigneshshanmugam vigneshshanmugam deleted the fix-throttling branch January 10, 2023 20:32
@paulb-elastic
Copy link
Contributor

@vigneshshanmugam with elastic/kibana#148344 not in 8.6, does it matter than this is merged and will be included in beta.40 which will be released before 8.7? (or does it just fail silently and not disable throttling with earlier versions of Kibana?)

@dominiqueclarke
Copy link
Contributor

@paulb-elastic It won't fail silently, users will receive the following error in 8.6

   > Failed to save or update monitor. Configuration is not valid: monitor(test-example-journey)
       Invalid value "false" supplied to "throttling"

@paulb-elastic
Copy link
Contributor

@dominiqueclarke ok, thanks. I see that the Kibana fix has been backported to 8.6.1, so will be included with that when it comes out. We'll just need to remember that this won't work until that's available.

Actually, we should get the docs updated to reflect this new option too, I've raised elastic/observability-docs#2503 to capture this for 8.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable throttling
4 participants