Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] [Flapping] Edit flapping rule settings UI text #149086

Merged
merged 8 commits into from
Jan 24, 2023
Merged

[RAM] [Flapping] Edit flapping rule settings UI text #149086

merged 8 commits into from
Jan 24, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 18, 2023 •
edited
Loading

Summary

Relates to #143529

This PR edits some of the text and fixes the hover help that was added in #147774

Screenshots

Before

Flapping detection on (no hover help):
image

Flapping detection off:
image

After

Hover help for look back:
image

Hover help for threshold:
image

Help text when detection is off:
image

@lcawl lcawl mentioned this pull request Jan 18, 2023
Merged
@lcawl lcawl added backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0 docs ui-copy Review of UI copy with docs team is recommended and removed docs labels Jan 18, 2023
@lcawl lcawl marked this pull request as ready for review January 18, 2023 16:18
@lcawl lcawl requested a review from a team as a code owner January 18, 2023 16:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from JiaweiWu January 18, 2023 16:18
@lcawl lcawl mentioned this pull request Jan 18, 2023
Closed
@JiaweiWu
Copy link
Contributor

Here is the change to the switch label

on
off

JiaweiWu
JiaweiWu approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM!

@lcawl lcawl enabled auto-merge (squash) January 23, 2023 21:22
@lcawl lcawl disabled auto-merge January 23, 2023 21:47
@lcawl lcawl enabled auto-merge (squash) January 23, 2023 22:29
@lcawl lcawl merged commit bbc909b into elastic:main Jan 24, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 707.7KB 708.1KB +418.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl deleted the rule-settings-text branch January 24, 2023 01:17
@lcawl lcawl mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiaweiWu JiaweiWu JiaweiWu approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lcawl @elasticmachine @JiaweiWu @kibana-ci