New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Adds "Use full data" button to transform creation wizard. #150030
[ML] Transforms: Adds "Use full data" button to transform creation wizard. #150030
Conversation
359ee89
to
7bff681
Compare
Pinging @elastic/ml-ui (:ml) |
LGTM 🎉 |
I added some additional functional tests in 8bc4a76. The tests now do the following on each index pattern based transform creation test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM. Added a comment about the frozen data tier preference radio button event.
@@ -311,6 +331,14 @@ export const StepDefineForm: FC<StepDefineFormProps> = React.memo((props) => { | |||
</EuiFlexItem> | |||
</EuiFlexGroup> | |||
)} | |||
<FullTimeRangeSelector | |||
frozenDataPreference={frozenDataPreference} | |||
setFrozenDataPreference={setFrozenDataPreference} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A change to the frozen data preference is currently acting as a submit on the 'Use full data' button. I don't think this should trigger an event here - added an item to the parent issue #146187.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR with a fix for this is up here: #151673
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1865 🔴 Tests are still flaky, working on a fix ... |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1869 ✅ 50 runs passed! |
…zard. (elastic#150030) Adds the "Use full data" button including the option whether to include the frozen data tier to the transform creation wizard.
…zard. (elastic#150030) Adds the "Use full data" button including the option whether to include the frozen data tier to the transform creation wizard.
Summary
Part of #146187.
Adds the "Use full data" button including the option whether to include the frozen data tier to the transform creation wizard.
Checklist