Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Adds "Use full data" button to transform creation wizard. #150030

Merged
merged 9 commits into from Feb 7, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Feb 1, 2023

Summary

Part of #146187.

Adds the "Use full data" button including the option whether to include the frozen data tier to the transform creation wizard.

image

Checklist

@walterra walterra force-pushed the 146187b-transform-full-date-range branch from 359ee89 to 7bff681 Compare February 1, 2023 13:31
@walterra walterra marked this pull request as ready for review February 1, 2023 14:32
@walterra walterra requested a review from a team as a code owner February 1, 2023 14:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Feb 1, 2023

LGTM 🎉

@walterra
Copy link
Contributor Author

walterra commented Feb 2, 2023

I added some additional functional tests in 8bc4a76. The tests now do the following on each index pattern based transform creation test:

  • Sets date picker using quick-select to Last 15 minutes and checks there are no results.
  • Sets date picker using quick-select to Last 15 years and checks there are some results.
  • Again sets date picker using quick-select to Last 15 minutes and checks there are no results.
  • Then uses the Use full data button and checks there are again results.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Added a comment about the frozen data tier preference radio button event.

@@ -311,6 +331,14 @@ export const StepDefineForm: FC<StepDefineFormProps> = React.memo((props) => {
</EuiFlexItem>
</EuiFlexGroup>
)}
<FullTimeRangeSelector
frozenDataPreference={frozenDataPreference}
setFrozenDataPreference={setFrozenDataPreference}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change to the frozen data preference is currently acting as a submit on the 'Use full data' button. I don't think this should trigger an event here - added an item to the parent issue #146187.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR with a fix for this is up here: #151673

@walterra
Copy link
Contributor Author

walterra commented Feb 6, 2023

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1865

🔴 Tests are still flaky, working on a fix ...

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
transform 296 297 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 360.4KB 364.2KB +3.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra
Copy link
Contributor Author

walterra commented Feb 6, 2023

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1869

✅ 50 runs passed!

@walterra walterra merged commit 6a19f89 into elastic:main Feb 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 7, 2023
@walterra walterra deleted the 146187b-transform-full-date-range branch February 7, 2023 08:35
darnautov pushed a commit to darnautov/kibana that referenced this pull request Feb 7, 2023
…zard. (elastic#150030)

Adds the "Use full data" button including the option whether to include
the frozen data tier to the transform creation wizard.
benakansara pushed a commit to benakansara/kibana that referenced this pull request Feb 7, 2023
…zard. (elastic#150030)

Adds the "Use full data" button including the option whether to include
the frozen data tier to the transform creation wizard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Transforms ML transforms :ml release_note:enhancement v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants