Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly detection wizards: adds functional test for geo wizard #150942

Merged
merged 5 commits into from
Feb 14, 2023
Merged

[ML] Anomaly detection wizards: adds functional test for geo wizard #150942

merged 5 commits into from
Feb 14, 2023

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Feb 10, 2023 •
edited by kibanamachine
Loading

Summary

Adds functional tests for the geo wizard in anomaly detection

Flaky test runner build

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Feb 10, 2023
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner February 10, 2023 20:10
@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

qn895
qn895 reviewed Feb 13, 2023
View reviewed changes
x-pack/test/functional/services/ml/job_wizard_geo.ts Outdated
);
expect(comboBoxSelectedOptions).to.eql(
expectedIdentifier,
`Expected population field selection to be '${expectedIdentifier}' (got '${comboBoxSelectedOptions}')`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Expected geo field?

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

This has been updated and is ready for a final look when you get a chance 🙏 cc @pheyos, @qn895

pheyos
pheyos approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Local tests also ran fine, let's hope CI and flaky runner agree 😉

@qn895
Copy link
Member

qn895 commented Feb 14, 2023

LGTM 🎉

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -11.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 1fb3ef4 into elastic:main Feb 14, 2023
@alvarezmelissa87 alvarezmelissa87 deleted the ml-geo-wizard-functional-test branch February 14, 2023 17:57
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 14, 2023
Closed
14 tasks
@kibanamachine kibanamachine mentioned this pull request Feb 14, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2023
@alvarezmelissa87
[ML] Anomaly detection wizards: adds functional test for geo wizard (e…
78843fb 
…lastic#150942)

## Summary

Adds functional tests for the geo wizard in anomaly detection

[Flaky test runner
build](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1913)

### Checklist

Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Robert Oskamp <traeluki@gmail.com>
(cherry picked from commit 1fb3ef4)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 14, 2023
@kibanamachine @alvarezmelissa87
[8.7] [ML] Anomaly detection wizards: adds functional test for geo wi…
4c4abc6 
…zard (#150942) (#151194)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[ML] Anomaly detection wizards: adds functional test for geo wizard
(#150942)](#150942)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Melissa
Alvarez","email":"melissa.alvarez@elastic.co"},"sourceCommit":{"committedDate":"2023-02-14T17:57:42Z","message":"[ML]
Anomaly detection wizards: adds functional test for geo wizard
(#150942)\n\n## Summary\r\n\r\nAdds functional tests for the geo wizard
in anomaly detection\r\n\r\n[Flaky test
runner\r\nbuild](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1913)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Robert Oskamp
<traeluki@gmail.com>","sha":"1fb3ef499fdc9e999904b04eae6a2bdad76228b3","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","release_note:skip","v8.7.0","v8.8.0"],"number":150942,"url":"#150942
Anomaly detection wizards: adds functional test for geo wizard
(#150942)\n\n## Summary\r\n\r\nAdds functional tests for the geo wizard
in anomaly detection\r\n\r\n[Flaky test
runner\r\nbuild](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1913)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Robert Oskamp
<traeluki@gmail.com>","sha":"1fb3ef499fdc9e999904b04eae6a2bdad76228b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150942
Anomaly detection wizards: adds functional test for geo wizard
(#150942)\n\n## Summary\r\n\r\nAdds functional tests for the geo wizard
in anomaly detection\r\n\r\n[Flaky test
runner\r\nbuild](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1913)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Robert Oskamp
<traeluki@gmail.com>","sha":"1fb3ef499fdc9e999904b04eae6a2bdad76228b3"}}]}]
BACKPORT-->

Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
justinkambic pushed a commit to justinkambic/kibana that referenced this pull request Feb 23, 2023
@alvarezmelissa87 @kibanamachine
@pheyos @justinkambic
[ML] Anomaly detection wizards: adds functional test for geo wizard (e…
a6fc260 
…lastic#150942)

## Summary

Adds functional tests for the geo wizard in anomaly detection

[Flaky test runner
build](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1913)


### Checklist

Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Robert Oskamp <traeluki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibana-ci @kibanamachine @pheyos