[build] Fix config argument order #151052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot builds are currently being marked as release builds in the config service. This impacts the release property in package.json snapshot builds and pull request deployments.
jbudz
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
approved these changes
Feb 13, 2023
💔 Build FailedFailed CI StepsMetrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
|
The cloud deployment failure above is expected for now. We are creating the correct artifacts with more unit tests added - merging away. |
kibanamachine
added
v8.8.0
backport:skip
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
May 17, 2023
Snapshot builds are currently being marked as release builds in the config service. This impacts the release property in package.json snapshot builds and pull request deployments. This was introduced in elastic@1b85815#diff-dbea24da2a777429d025c1da037dd966d65bff2c97a7b78b82a33532f3ad06d9R63 (cherry picked from commit 17855ba)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
May 17, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[build] Fix config argument order (#151052)](#151052) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2023-02-13T21:48:28Z","message":"[build] Fix config argument order (#151052)\n\nSnapshot builds are currently being marked as release builds in the\r\nconfig service. This impacts the release property in package.json\r\nsnapshot builds and pull request deployments.\r\n\r\nThis was introduced in\r\nhttps://github.com/elastic/kibana/commit/1b8581540295fde746dae6b4a09d74fb5821bfef#diff-dbea24da2a777429d025c1da037dd966d65bff2c97a7b78b82a33532f3ad06d9R63","sha":"17855ba5a240ce2cd60f318b49f0040d0cfabbbd","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","ci:cloud-deploy","v8.8.0"],"number":151052,"url":"#151052 Fix config argument order (#151052)\n\nSnapshot builds are currently being marked as release builds in the\r\nconfig service. This impacts the release property in package.json\r\nsnapshot builds and pull request deployments.\r\n\r\nThis was introduced in\r\nhttps://github.com/elastic/kibana/commit/1b8581540295fde746dae6b4a09d74fb5821bfef#diff-dbea24da2a777429d025c1da037dd966d65bff2c97a7b78b82a33532f3ad06d9R63","sha":"17855ba5a240ce2cd60f318b49f0040d0cfabbbd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151052 Fix config argument order (#151052)\n\nSnapshot builds are currently being marked as release builds in the\r\nconfig service. This impacts the release property in package.json\r\nsnapshot builds and pull request deployments.\r\n\r\nThis was introduced in\r\nhttps://github.com/elastic/kibana/commit/1b8581540295fde746dae6b4a09d74fb5821bfef#diff-dbea24da2a777429d025c1da037dd966d65bff2c97a7b78b82a33532f3ad06d9R63","sha":"17855ba5a240ce2cd60f318b49f0040d0cfabbbd"}}]}] BACKPORT--> Co-authored-by: Jon <jon@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot builds are currently being marked as release builds in the config service. This impacts the release property in package.json snapshot builds and pull request deployments.
This was introduced in 1b85815#diff-dbea24da2a777429d025c1da037dd966d65bff2c97a7b78b82a33532f3ad06d9R63