Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add functional tests for Field stats flyout in Anomaly detection job creation wizards #151336

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 15, 2023

Summary

Follow up of #150927 and part of #147170. This PR adds functional tests for the Field stats flyout to the Transforms creation wizards.

Flaky test suite runner successful after 50 runs ✅

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 self-assigned this Feb 15, 2023
@qn895 qn895 added :ml test_ui_functional v8.7.0 v8.8.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Anomaly Detection ML anomaly detection labels Feb 15, 2023
@qn895 qn895 marked this pull request as ready for review February 15, 2023 17:08
@qn895 qn895 requested a review from a team as a code owner February 15, 2023 17:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 mentioned this pull request Feb 15, 2023
14 tasks
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just one small suggestion.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit bd89b11 into elastic:main Feb 16, 2023
@qn895 qn895 deleted the ml-ad-stats-flyout-tests branch February 16, 2023 20:35
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 16, 2023
…ection job creation wizards (#151336) (#151513)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[ML] Add functional tests for Field stats flyout in Anomaly detection
job creation wizards
(#151336)](#151336)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Quynh Nguyen
(Quinn)","email":"43350163+qn895@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-16T20:35:43Z","message":"[ML]
Add functional tests for Field stats flyout in Anomaly detection job
creation wizards
(#151336)","sha":"bd89b11576f75139f47669d369deceb9b94302c6","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","Feature:Anomaly
Detection","test_ui_functional","release_note:skip","v8.7.0","v8.8.0"],"number":151336,"url":"#151336
Add functional tests for Field stats flyout in Anomaly detection job
creation wizards
(#151336)","sha":"bd89b11576f75139f47669d369deceb9b94302c6"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151336
Add functional tests for Field stats flyout in Anomaly detection job
creation wizards
(#151336)","sha":"bd89b11576f75139f47669d369deceb9b94302c6"}}]}]
BACKPORT-->

Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants