-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add functional tests for Field stats flyout in Transforms & DFA creation wizard #150927
[ML] Add functional tests for Field stats flyout in Transforms & DFA creation wizard #150927
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
Started flaky test suite runner... |
x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts
Outdated
Show resolved
Hide resolved
Also, the flaky test runner has some failures, looking into these... |
x-pack/test/functional/apps/transform/creation/index_pattern/creation_index_pattern.ts
Outdated
Show resolved
Hide resolved
Started flaky test suite runner... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Let's hope that the initial flakiness has been fixed by the changes 🤞
10d9917
to
69d124f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @qn895 |
The flaky test runner failed and from the log it looks like steps are done in a wrong order:
So the test actually closes the flyout and then tries to validate the top values, which obviously can't work. The code for this bit clearly defines a different order: first check the top values then close the flyout:
So I'm not exactly sure what's going wrong here. Also, it doesn't reproduce on my local and the PR CI run also didn't show that error. Maybe the flaky test runner had an issue or was running from a different commit level? Might be worth to give it another run. |
Ran the Flaky test suite runner again and it was successful after 50 tries ✅ |
…creation wizard (elastic#150927) (cherry picked from commit 7906c76)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…& DFA creation wizard (#150927) (#151332) # Backport This will backport the following commits from `main` to `8.7`: - [[ML] Add functional tests for Field stats flyout in Transforms & DFA creation wizard (#150927)](#150927) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"43350163+qn895@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-15T15:47:47Z","message":"[ML] Add functional tests for Field stats flyout in Transforms & DFA creation wizard (#150927)","sha":"7906c76749fa89f56df626e1e4012e01bfe14753","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","v8.7.0","v8.8.0"],"number":150927,"url":"#150927 Add functional tests for Field stats flyout in Transforms & DFA creation wizard (#150927)","sha":"7906c76749fa89f56df626e1e4012e01bfe14753"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150927 Add functional tests for Field stats flyout in Transforms & DFA creation wizard (#150927)","sha":"7906c76749fa89f56df626e1e4012e01bfe14753"}}]}] BACKPORT--> Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
Summary
Part of #147170. This PR adds functional tests for the Field stats flyout to the Transforms creation wizards.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers