Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip diff flamegraph #151437

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Update tooltip diff flamegraph #151437

merged 3 commits into from
Feb 16, 2023

Conversation

boriskirov
Copy link
Contributor

@boriskirov boriskirov commented Feb 16, 2023 •
edited by kibanamachine
Loading

Summary

Updated the copy in the tooltip based on our discussion in this ticket: https://github.com/elastic/prodfiler/issues/3001

image

@boriskirov boriskirov added release_note:skip Skip the PR/issue when compiling release notes v8.7.0 labels Feb 16, 2023
@boriskirov boriskirov requested a review from a team as a code owner February 16, 2023 12:30
@boriskirov boriskirov mentioned this pull request Feb 16, 2023
Closed
rockdaboot
rockdaboot approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rockdaboot rockdaboot enabled auto-merge (squash) February 16, 2023 14:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 258.2KB 258.9KB +689.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rockdaboot rockdaboot merged commit ff061ff into main Feb 16, 2023
@rockdaboot rockdaboot deleted the update-tooltip-diff-flamegraph branch February 16, 2023 16:08
@kibanamachine kibanamachine mentioned this pull request Feb 16, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2023
@boriskirov
Update tooltip diff flamegraph (elastic#151437)
096b4ff 
## Summary

Updated the copy in the tooltip based on our discussion in this ticket:
elastic/prodfiler#3001

(cherry picked from commit ff061ff)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@mdbirnstiehl
Copy link
Contributor

I would recommend something along the lines of:

Select Normalize by Time to compare a set of machines across different time periods. For example, if you compare the last hour to the last 24 hours, the shorter timeframe (1 hour) is multiplied to match the longer timeframe (24 hours).

Select Normalize by Scale factor and set your reference scale factor to compare a set of machines of different sizes. For example, you can compare a deployment of 10% of machines to a deployment of 90% of machines.

I'm a little confused by the provide an appropriate factor to multiply the right-hand side with part of the second paragraph. If I could see the feature or a screenshot of this part, I could recommend something to address that part of the tool tip.

@rockdaboot
Copy link
Contributor

Thanks for the suggestion @mdbirnstiehl
Here is a screenshot of the page
Screenshot_20230216_175505

kibanamachine added a commit that referenced this pull request Feb 16, 2023
@kibanamachine @boriskirov
[8.7] Update tooltip diff flamegraph (#151437) (#151479)
bdfa747 
# Backport

This will backport the following commits from `main` to `8.7`:
- [Update tooltip diff flamegraph
(#151437)](#151437)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Boris
Kirov","email":"boris.kirov@elastic.co"},"sourceCommit":{"committedDate":"2023-02-16T16:08:42Z","message":"Update
tooltip diff flamegraph (#151437)\n\n## Summary\r\n\r\nUpdated the copy
in the tooltip based on our discussion in this
ticket:\r\nhttps://github.com/elastic/prodfiler/issues/3001","sha":"ff061ff984d77fe1614e89288f3e11207659809a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.7.0","v8.8.0"],"number":151437,"url":"#151437
tooltip diff flamegraph (#151437)\n\n## Summary\r\n\r\nUpdated the copy
in the tooltip based on our discussion in this
ticket:\r\nhttps://github.com/elastic/prodfiler/issues/3001","sha":"ff061ff984d77fe1614e89288f3e11207659809a"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151437
tooltip diff flamegraph (#151437)\n\n## Summary\r\n\r\nUpdated the copy
in the tooltip based on our discussion in this
ticket:\r\nhttps://github.com/elastic/prodfiler/issues/3001","sha":"ff061ff984d77fe1614e89288f3e11207659809a"}}]}]
BACKPORT-->

Co-authored-by: Boris Kirov <boris.kirov@elastic.co>
@mdbirnstiehl
Copy link
Contributor

Thanks for the input, I would suggest:

Select Normalize by Time to compare a set of machines across different time periods. For example, if you compare the last hour to the last 24 hours, the shorter timeframe (1 hour) is multiplied to match the longer timeframe (24 hours).

Select Normalize by Scale factor and set your Baseline and Comparison scale factors to compare a set of machines of different sizes. For example, you can compare a deployment of 10% of machines to a deployment of 90% of machines.

@boriskirov boriskirov mentioned this pull request Feb 20, 2023
Merged
boriskirov added a commit that referenced this pull request Feb 21, 2023
@boriskirov @rockdaboot
Update tooltip diff flamegraph (#151625)
d5674c7 
## Summary

We recently reviewed the final copy for the `Normalize by` menu in the
Diff Flamegraph with the writing team and we have the final copy that we
will use there. This PR is aiming to update that.

Related to:
#151437

---------

Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2023
@boriskirov
Update tooltip diff flamegraph (elastic#151625)
987b1ad 
## Summary

We recently reviewed the final copy for the `Normalize by` menu in the
Diff Flamegraph with the writing team and we have the final copy that we
will use there. This PR is aiming to update that.

Related to:
elastic#151437

---------

Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
(cherry picked from commit d5674c7)
kibanamachine added a commit that referenced this pull request Feb 21, 2023
@kibanamachine @boriskirov
[8.7] Update tooltip diff flamegraph (#151625) (#151668)
0899980 
# Backport

This will backport the following commits from `main` to `8.7`:
- [Update tooltip diff flamegraph
(#151625)](#151625)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Boris
Kirov","email":"boris.kirov@elastic.co"},"sourceCommit":{"committedDate":"2023-02-21T08:54:00Z","message":"Update
tooltip diff flamegraph (#151625)\n\n## Summary\r\n\r\nWe recently
reviewed the final copy for the `Normalize by` menu in the\r\nDiff
Flamegraph with the writing team and we have the final copy that
we\r\nwill use there. This PR is aiming to update that.\r\n\r\nRelated
to:\r\nhttps://github.com//pull/151437\r\n\r\n---------\r\n\r\nCo-authored-by:
Tim Rühsen
<tim.ruhsen@elastic.co>","sha":"d5674c70afcaabf57551a73dcfe711f94140e5fd","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.7.0","v8.8.0"],"number":151625,"url":"#151625
tooltip diff flamegraph (#151625)\n\n## Summary\r\n\r\nWe recently
reviewed the final copy for the `Normalize by` menu in the\r\nDiff
Flamegraph with the writing team and we have the final copy that
we\r\nwill use there. This PR is aiming to update that.\r\n\r\nRelated
to:\r\nhttps://github.com//pull/151437\r\n\r\n---------\r\n\r\nCo-authored-by:
Tim Rühsen
<tim.ruhsen@elastic.co>","sha":"d5674c70afcaabf57551a73dcfe711f94140e5fd"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151625
tooltip diff flamegraph (#151625)\n\n## Summary\r\n\r\nWe recently
reviewed the final copy for the `Normalize by` menu in the\r\nDiff
Flamegraph with the writing team and we have the final copy that
we\r\nwill use there. This PR is aiming to update that.\r\n\r\nRelated
to:\r\nhttps://github.com//pull/151437\r\n\r\n---------\r\n\r\nCo-authored-by:
Tim Rühsen
<tim.ruhsen@elastic.co>","sha":"d5674c70afcaabf57551a73dcfe711f94140e5fd"}}]}]
BACKPORT-->

Co-authored-by: Boris Kirov <boris.kirov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@boriskirov @kibana-ci @kibanamachine @mdbirnstiehl @rockdaboot