Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip diff flamegraph #151437

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Update tooltip diff flamegraph #151437

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25c3ab5
updating the copy in the tooltip of the normalization selector
boriskirov Feb 15, 2023
3a83bb5
fixing the i18n
boriskirov Feb 16, 2023
98f0d87
Merge branch 'main' into update-tooltip-diff-flamegraph
rockdaboot Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions x-pack/plugins/profiling/public/components/flame_graphs_view/normalization_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,32 @@ export function NormalizationMenu(props: Props) {
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiIconTip
content={i18n.translate(
'xpack.profiling.flameGraphNormalizationMenu.normalizeByTooltip',
{
defaultMessage:
'Normalization is the process of organizing a database to reduce redundancy and improve data integrity.',
}
)}
content={
<EuiFlexGroup direction="column" gutterSize="s">
<EuiFlexItem>
<span>
{i18n.translate(
'xpack.profiling.flameGraphNormalizationMenu.normalizeByTimeTooltip',
{
defaultMessage:
'To compare a set of machines over time periods of different lengths (for example: Compare the last hour against the last 24h), choose Normalize by Time. The number of samples on the shorter timeframe will be multiplied to match the longer timeframe (in this example, by 24).',
}
)}
</span>
</EuiFlexItem>
<EuiFlexItem>
<span>
{i18n.translate(
'xpack.profiling.flameGraphNormalizationMenu.normalizeByScaleTooltip',
{
defaultMessage:
'To compare differently-sized sets of machines (e.g. a deployment on 10% of machines against a deployment on 90% of machines), choose Scale Factor and provide an appropriate factor to multiply the right-hand side with.',
}
)}
</span>
</EuiFlexItem>
</EuiFlexGroup>
}
position="right"
/>
</EuiFlexItem>
Expand Down