Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve Visualize Loader #15157

Merged
merged 28 commits into from
Dec 1, 2017
Merged

Refactor and improve Visualize Loader #15157

merged 28 commits into from
Dec 1, 2017

Commits on Nov 30, 2017

  1. Simplify promise setup logic

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    41696ad View commit details
    Browse the repository at this point in the history

  2. Import template from own file

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    20b7beb View commit details
    Browse the repository at this point in the history

  3. Use angular.element instead of jquery

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    8781d30 View commit details
    Browse the repository at this point in the history

  4. Add documentation for loader methods

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    0ea987f View commit details
    Browse the repository at this point in the history

  5. Add params.append

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    356b595 View commit details
    Browse the repository at this point in the history

  6. Remove params.editorMode

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    b952e17 View commit details
    Browse the repository at this point in the history

  7. Clarify when returned promise resolves

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    80a3289 View commit details
    Browse the repository at this point in the history

  8. Add element to handler

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    5973c2f View commit details
    Browse the repository at this point in the history

  9. Allow setting CSS class via loader

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    e0f5035 View commit details
    Browse the repository at this point in the history

  10. Use render-counter on visualize

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    1c87ef1 View commit details
    Browse the repository at this point in the history

  11. Use Angular run method to get access to Private service

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    8b891ad View commit details
    Browse the repository at this point in the history

  12. Allow adding data-attributes to the vis element

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    a017fd9 View commit details
    Browse the repository at this point in the history

  13. Refactor loader to return an EmbeddedVisualizeHandler instance

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    fbdb108 View commit details
    Browse the repository at this point in the history

  14. Use this.destroy for previous API

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    618a59b View commit details
    Browse the repository at this point in the history

  15. Remove fallback then method, due to bugs

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    b15b54a View commit details
    Browse the repository at this point in the history

  16. Reject promise from withId when id not found

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    8b89264 View commit details
    Browse the repository at this point in the history

  17. Add tests

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    c1df85e View commit details
    Browse the repository at this point in the history

  18. Change developer documentation

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    dd65312 View commit details
    Browse the repository at this point in the history

  19. Revert "Use Angular run method to get access to Private service" 

    This reverts commit 160e47d.
    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    49ca6d4 View commit details
    Browse the repository at this point in the history

  20. Rename parameter for more clarity

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    c6f21b6 View commit details
    Browse the repository at this point in the history

  21. Add more documentation about appState

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    c667336 View commit details
    Browse the repository at this point in the history

  22. Fix broken test utils

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    ecba46c View commit details
    Browse the repository at this point in the history

  23. Use chrome to get access to Angular

    Tim Roes committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    cafdda8 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2017

  1. Move loader to its own folder

    Tim Roes committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    0f8ed06 View commit details
    Browse the repository at this point in the history

  2. Use a method instead of getter for element

    Tim Roes committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    30d2c75 View commit details
    Browse the repository at this point in the history

  3. Add listeners for renderComplete events

    Tim Roes committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    71e3eb7 View commit details
    Browse the repository at this point in the history

  4. Use typedef to document params

    Tim Roes committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    01a673d View commit details
    Browse the repository at this point in the history

  5. Fix documentation

    Tim Roes committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    fd0758a View commit details
    Browse the repository at this point in the history