-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and improve Visualize Loader #15157
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
41696ad
Simplify promise setup logic
20b7beb
Import template from own file
8781d30
Use angular.element instead of jquery
0ea987f
Add documentation for loader methods
356b595
Add params.append
b952e17
Remove params.editorMode
80a3289
Clarify when returned promise resolves
5973c2f
Add element to handler
e0f5035
Allow setting CSS class via loader
1c87ef1
Use render-counter on visualize
8b891ad
Use Angular run method to get access to Private service
a017fd9
Allow adding data-attributes to the vis element
fbdb108
Refactor loader to return an EmbeddedVisualizeHandler instance
618a59b
Use this.destroy for previous API
b15b54a
Remove fallback then method, due to bugs
8b89264
Reject promise from withId when id not found
c1df85e
Add tests
dd65312
Change developer documentation
49ca6d4
Revert "Use Angular run method to get access to Private service"
c6f21b6
Rename parameter for more clarity
c667336
Add more documentation about appState
ecba46c
Fix broken test utils
cafdda8
Use chrome to get access to Angular
0f8ed06
Move loader to its own folder
30d2c75
Use a method instead of getter for element
71e3eb7
Add listeners for renderComplete events
01a673d
Use typedef to document params
fd0758a
Fix documentation
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
110 changes: 46 additions & 64 deletions
110
docs/development/visualize/development-embedding-visualizations.asciidoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the parts describing the params of directive should be moved here as well (not just deleted) ...
like time-range, showSpyPanel, uiState and appState should probably have some explanation, as well as newly introduced class and data attributes that can be passed in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry, i missed the part where you reference the source code and that all parameters are actually described there. ignore my above comment