Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] added _meta field has_experimental_data_stream_indexing_features #151853

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Feb 22, 2023

Summary

Closes #150917

Added has_experimental_data_stream_indexing_features meta field to indicate that component/index template has these setting turned on.

The component template has this field set when synthetic_source or the doc_value_only settings are enabled.
The index template has the field set when tsdb setting is enabled.

Open question:

  • Alternatively we could move the meta field to only be in the component template, also for tsdb. I'm not sure which would be more intuitive (tsdb only makes changes to the index template, the other settings in component template).
    @kpollich WDYT?

To test:

  • enable experimentalDataStreamSettings feature flag
  • add a System integration policy and enable one of the experimental features on one data stream e.g. Doc only value
  • Check the corresponding component template in Stack Management that is has the new _meta field.

image

image

Checklist

@juliaElastic juliaElastic requested a review from a team as a code owner February 22, 2023 13:24
@juliaElastic juliaElastic self-assigned this Feb 22, 2023
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we could move the meta field to only be in the component template, also for tsdb. I'm not sure which would be more intuitive (tsdb only makes changes to the index template, the other settings in component template).
@kpollich WDYT?

I think it makes the most sense to add the _meta property to whichever template directly includes the experimental functionality. So for TSDB, including the _meta property in the index template makes sense. For the others, including the _meta property in the component templates makes sense. So this implementation LGTM.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / Lists plugin Lists API "after all" hook for "should return a 400 if endpoint exception entry has disallowed field"
  • [job] [logs] FTR Configs #49 / Lists plugin Lists API "before all" hook for "should return a 400 if an endpoint exception item with a list-based entry is provided"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 8440a29 into elastic:main Feb 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0
Projects
None yet
5 participants