Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add has_experimental_data_stream_indexing_features: true metadata to integration index/component templates when experimental indexing features are enabled #150917

Closed
kpollich opened this issue Feb 10, 2023 · 1 comment · Fixed by #151853
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@kpollich
Copy link
Member

Part of #132818

It'd be helpful to support engineers to be able to quickly determine whether a certain integration is using experimental indexing features when debugging ingest issues. Adding a _meta value to index/component templates for experimental indexing features should be a fairly quick solution to providing this information.

When Fleet PUTs to these templates, we should ensure a _meta value is included that indicates whether the given template object includes experimental settings.

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic added a commit that referenced this issue Feb 22, 2023
…atures` (#151853)

## Summary

Closes #150917

Added `has_experimental_data_stream_indexing_features` meta field to
indicate that component/index template has these setting turned on.

The component template has this field set when `synthetic_source` or the
`doc_value_only` settings are enabled.
The index template has the field set when `tsdb` setting is enabled. 

Open question:
- Alternatively we could move the meta field to only be in the component
template, also for `tsdb`. I'm not sure which would be more intuitive
(`tsdb` only makes changes to the index template, the other settings in
component template).
@kpollich WDYT?

To test:
- enable `experimentalDataStreamSettings` feature flag
- add a System integration policy and enable one of the experimental
features on one data stream e.g. Doc only value
- Check the corresponding component template in Stack Management that is
has the new _meta field.

<img width="1413" alt="image"
src="https://user-images.githubusercontent.com/90178898/220637550-3919ca2e-652b-4166-8353-cfced6b0deb9.png">
<img width="978" alt="image"
src="https://user-images.githubusercontent.com/90178898/220637661-43c5d2fc-6a73-4afe-8280-b17dd020b589.png">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants