Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Metric non-clickable if not filterable #154212

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 3, 2023

Summary

Closes #153621

In case metric is not filterable the cursor should not indicate that it is.
1

Checklist

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.8.0 labels Apr 3, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 71.3KB 71.3KB +6.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review April 3, 2023 09:34
@stratoula stratoula requested a review from a team as a code owner April 3, 2023 09:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon
Copy link
Contributor

Is it just the cursor interaction that needs to change, or should the background animation also be removed?

@stratoula
Copy link
Contributor Author

I dont think we should remove the background iteration, I see the same on the EC docs that don't have a clickable action.

@markov00
Copy link
Member

markov00 commented Apr 3, 2023

@stratoula I'm adding a fix to remove the background interaction if there is no click handler attached to the chart elastic/elastic-charts#2010

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You're so fast!!

@stratoula stratoula merged commit 9bfd8b6 into elastic:main Apr 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Disable the click event for metrics that use the count()
6 participants