Use visualize loader for dashboards #15444
Conversation
timroes
added
Feature:Dashboard
timroes
force-pushed
the
vizualise-loader-dashboard
branch
from
e85c129
to
49794d1
Compare
| cssClass: `panel-content ${savedObject.vis.type.name}`, | ||
| // The chrome is permanently hidden in "embed mode" in which case we don't want to show the spy pane, since | ||
| // we deem that situation to be more public facing and want to hide more detailed information. | ||
| showSpyPanel: !chrome.getIsChromePermanentlyHidden(), |
There was a problem hiding this comment.
can you explain why this instead of getShouldShowSpyPane() which was use before ?
There was a problem hiding this comment.
getShouldShowSpyPane returned that value. I talked to Stacey, and there is currently no scenario where this value can actually change while a visualization is visible, so I just replaced it by setting it initially to this value. Also it wouldn't have worked beforehand properly, since changing that permanently hidden value isn't triggering any callback, and is not within the angular scope, so the <visualize> as rendered by dashboards would anyway not have picked up any changes (IF there would be a case where it changes, which doesn't exist).
| data-shared-item | ||
| data-title="{{sharedItemTitle}}" | ||
| data-description="{{savedObj.description}}" | ||
| render-counter |
There was a problem hiding this comment.
is render-counter still used ? if not, why not ?
There was a problem hiding this comment.
I assumed that it's still used. The visualize loader adds this to every visualization (see template). Since this directive has a rather small overhead I thought it's not bad having this on any embedded visualization, and I didn't want to implement a generic param to add angular directives to the <visualize> via the loader, since I considered this worth (regarding possible performance impacts and security).
There was a problem hiding this comment.
we still need render-counter for now, for reporting. however, @kobelb has an idea to remove this in favor of a render-state flag. he is looking into it and will put up a proposal.
* Use visualize loader to in visualize embeddable * Remove old template * Fix broken property name
This PR changes the visualization embeddable for dashboards to use the visualize loader instead of rendering the
<visualize>Angular tag itself.Fixes #15153