Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix error messages on Rule Details page taking too much space #154555

Closed
wants to merge 8 commits into from
Closed

[Security Solution] Fix error messages on Rule Details page taking too much space #154555

wants to merge 8 commits into from

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented Apr 6, 2023 •
edited

Summary

When a large "last execution" error message is displayed on Rule Details page it takes too much vertical space:

https://user-images.githubusercontent.com/2946766/214444343-dde0d9cd-6bc7-4aca-a6cf-07891d206888.png

This PR sets max-height for the error callout and adds vertical/horizontal scrolling. It also adds a button to copy the error message content to clipboard.
Screenshot 2023-04-15 at 13 26 55

Another addition is a button to expand a row in the Execution Log to view / copy a full error message.
Screenshot 2023-04-15 at 12 55 10

Checklist

For maintainers

@nikitaindik nikitaindik added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Monitoring Security Solution Detection Rule Monitoring Team:Detection Rule Management Security Detection Rule Management Team Feature:Rule Details Security Solution Detection Rule Details backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.8.0 labels Apr 6, 2023
@nikitaindik nikitaindik self-assigned this Apr 6, 2023
@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
600842b

Please, read and sign the above mentioned agreement if you want to contribute to this project

@nikitaindik
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3808 3809 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.9MB 15.9MB +10.8KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

@nikitaindik nikitaindik deleted the truncate-rule-details-callout-text branch April 15, 2023 22:39
@joepeeples joepeeples mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikitaindik nikitaindik

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Rule Details Security Solution Detection Rule Details Feature:Rule Monitoring Security Solution Detection Rule Monitoring release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.2 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nikitaindik @kibana-ci @banderror @kibanamachine