-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Yarn #15485
Switch to Yarn #15485
Changes from 23 commits
f69b9ac
d50271b
c73c34c
e37bc17
00aa707
aa0d2b2
2f0c85c
3614219
a250507
51f0f35
eee502c
93a1c89
455800f
936c135
2d4a89b
7c946ac
35573d1
3ade68c
11ef811
ca1778b
dfde46c
1c91610
d5f0497
f08c194
c990e52
309b462
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { exec } from 'child_process'; | ||
module.exports = function (grunt) { | ||
grunt.registerTask('_build:installDependencies', function () { | ||
// We rely on a local version of Yarn that contains the bugfix from | ||
// https://github.com/yarnpkg/yarn/pull/5059. Once this fix is merged | ||
// and released we can use Yarn directly in the build. | ||
const yarn = require.resolve('../vendor/yarn-1.3.2-with-ignore-fix.js'); | ||
|
||
exec(`${yarn} --production --ignore-optional --frozen-lockfile`, { | ||
cwd: grunt.config.process('<%= root %>/build/kibana') | ||
}, this.async()); | ||
}); | ||
}; |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ module.exports = function () { | |
devSource: { | ||
options: { mode: true }, | ||
src: [ | ||
'yarn.lock', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense to add yarn.lock to the build, but we should also remove it after installing dependencies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ++ done |
||
'src/**', | ||
'!src/**/__tests__/**', | ||
'!src/test_utils/**', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be using
tasks/vendor/yarn-1.3.2-with-ignore-fix.js
or am I missing something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should probably do that. I'll fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to need to put this back once yarnpkg/yarn#5059 is merged but 🤷♂️