Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] kibana.alert.url #155309

Merged
merged 7 commits into from Apr 20, 2023
Merged

[RAM] kibana.alert.url #155309

merged 7 commits into from Apr 20, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Apr 19, 2023

Add alert url as data to allow our user to go back to the details url in kibana

@XavierM XavierM requested review from a team as code owners April 19, 2023 18:42
@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 labels Apr 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kdelemme
Copy link
Contributor

Can we use this to format the link used by the "View in app" button and the reason message? I'm currently doing this for SLO: #155320 but using this new field might be better and space aware.

@XavierM
Copy link
Contributor Author

XavierM commented Apr 19, 2023

Can we use this to format the link used by the "View in app" button and the reason message? I'm currently doing this for SLO: #155320 but using this new field might be better and space aware.

you will have to do it during the execution but this is related to show the alert details url like @michaelolo24 is doing in this #155069

Comment on lines +159 to +165
[ALERT_URL]: {
type: 'keyword',
array: false,
index: false,
required: false,
ignore_above: 2048,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we intentionally making this field doc values only? What are the intended use cases for this field mapping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we are not going to search on this field, it is just for representation.

@simianhacker simianhacker self-requested a review April 20, 2023 20:43
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / cases security and spaces enabled: basic Common delete_comments alerts security_solution should delete case ID from the alert schema when the user does NOT have access to the alert

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/rule-data-utils 101 102 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +72.0B
infra 2.0MB 2.0MB +72.0B
observability 1.1MB 1.1MB +72.0B
securitySolution 9.1MB 9.1MB +273.0B
triggersActionsUi 1.4MB 1.4MB +144.0B
total +633.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 32.2KB 32.3KB +50.0B
infra 90.6KB 90.7KB +50.0B
observability 74.5KB 74.5KB +50.0B
triggersActionsUi 84.3KB 84.3KB +50.0B
total +200.0B
Unknown metric groups

API count

id before after diff
@kbn/rule-data-utils 104 105 +1

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

@XavierM XavierM merged commit 59f8635 into elastic:main Apr 20, 2023
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
Add alert url as data to allow our user to go back to the details url in
kibana
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants