Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slo): add link to slo details page from alert #155320

Merged
merged 1 commit into from
Apr 20, 2023
Merged

chore(slo): add link to slo details page from alert #155320

merged 1 commit into from
Apr 20, 2023

Conversation

kdelemme
Copy link
Contributor

Resolves #155311

馃摑 Summary

This changes the link of the alert to the slo details page instead of the slo dashboard page.

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Apr 19, 2023
@kdelemme kdelemme self-assigned this Apr 19, 2023
@kdelemme kdelemme marked this pull request as ready for review April 19, 2023 20:00
@kdelemme kdelemme requested a review from a team as a code owner April 19, 2023 20:00
@apmmachine
Copy link
Contributor

馃 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme kdelemme mentioned this pull request Apr 19, 2023
Merged
@kibana-ci
Copy link
Collaborator

馃挌 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 513 514 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 74.4KB 74.4KB +15.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

CoenWarmer
CoenWarmer approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdelemme kdelemme merged commit 79969fb into elastic:main Apr 20, 2023
7 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023
@kdelemme kdelemme deleted the chore/redirect-to-slo-details branch April 20, 2023 10:56
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
@kdelemme @nikitaindik
chore(slo): add link to slo details page from alert (elastic#155320)
48354d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoenWarmer CoenWarmer CoenWarmer approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] redirect to the slo details page from an alert
6 participants
@kdelemme @apmmachine @elasticmachine @kibana-ci @CoenWarmer @kibanamachine