Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove 'Tech Preview' labels from EA workflows #156514

Merged
merged 1 commit into from May 4, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented May 3, 2023

issue: https://github.com/elastic/security-team/issues/6544

Summary

Remove the Technical Preview label from the following UI pages

  • (Must Do) Entity Analytics dashboard panels

Image

  • (Must Do) Alert Flyout

Image

  • All Hosts/ Users
    Image

  • Host/ User Details

Image

Image

  • Host/ Users Flyout

Image

Retain the Technical Preview label in the following (No Changes):

  • Enablement workflow from the EA dashboard
  • Information message in flouts

image

@machadoum machadoum changed the title wip [Security Solution] Remove 'Tech Preview' labels from EA workflows May 3, 2023
@machadoum machadoum self-assigned this May 3, 2023
@machadoum machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.8.0 release_note:fix labels May 3, 2023
@machadoum machadoum marked this pull request as ready for review May 3, 2023 13:53
@machadoum machadoum requested review from a team as code owners May 3, 2023 13:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the quick change @machadoum LGTM

Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -90.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit f5c12dc into elastic:main May 4, 2023
21 checks passed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 4, 2023
kibanamachine added a commit that referenced this pull request May 4, 2023
…ows (#156514) (#156642)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Remove 'Tech Preview' labels from EA workflows
(#156514)](#156514)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T07:26:45Z","message":"[Security
Solution] Remove 'Tech Preview' labels from EA workflows
(#156514)\n\nissue:
elastic/security-team#6544
Summary\r\n\r\n## Remove the `Technical Preview` label from the
following UI pages\r\n- [x] (Must Do) Entity Analytics dashboard
panels\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752482-90772171-99d4-4db1-b875-6fb3a00cd91e.png)\r\n\r\n-
[x] (Must Do) Alert
Flyout\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752377-e95c0c92-357b-4b5f-b03f-776457000b1f.png)\r\n\r\n-
[x] All Hosts/
Users\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752578-951241aa-1f1f-4693-99d0-636e2e53e449.png)\r\n\r\n-
[x] Host/ User
Details\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752661-4a03db27-94a0-451f-bf58-ef911573c5e1.png)\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752854-46263685-7440-44db-9d3b-bb9177f55c6a.png)\r\n\r\n\r\n-
[x] Host/ Users
Flyout\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235753556-256bb920-82f6-4129-8cdf-00a88286fc88.png)\r\n\r\n\r\n\r\n\r\n##
Retain the `Technical Preview` label in the following (No Changes):\r\n-
[x] Enablement workflow from the EA dashboard\r\n- [x] Information
message in flouts\r\n<img width=\"719\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/79533936/235903678-f982d483-7064-4172-ad1a-3a18b155c430.png\">","sha":"f5c12dc1b0aed3fa02a1bf141b58bac2968351cc","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.8.0","v8.9.0"],"number":156514,"url":"#156514
Solution] Remove 'Tech Preview' labels from EA workflows
(#156514)\n\nissue:
elastic/security-team#6544
Summary\r\n\r\n## Remove the `Technical Preview` label from the
following UI pages\r\n- [x] (Must Do) Entity Analytics dashboard
panels\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752482-90772171-99d4-4db1-b875-6fb3a00cd91e.png)\r\n\r\n-
[x] (Must Do) Alert
Flyout\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752377-e95c0c92-357b-4b5f-b03f-776457000b1f.png)\r\n\r\n-
[x] All Hosts/
Users\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752578-951241aa-1f1f-4693-99d0-636e2e53e449.png)\r\n\r\n-
[x] Host/ User
Details\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752661-4a03db27-94a0-451f-bf58-ef911573c5e1.png)\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752854-46263685-7440-44db-9d3b-bb9177f55c6a.png)\r\n\r\n\r\n-
[x] Host/ Users
Flyout\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235753556-256bb920-82f6-4129-8cdf-00a88286fc88.png)\r\n\r\n\r\n\r\n\r\n##
Retain the `Technical Preview` label in the following (No Changes):\r\n-
[x] Enablement workflow from the EA dashboard\r\n- [x] Information
message in flouts\r\n<img width=\"719\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/79533936/235903678-f982d483-7064-4172-ad1a-3a18b155c430.png\">","sha":"f5c12dc1b0aed3fa02a1bf141b58bac2968351cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156514","number":156514,"mergeCommit":{"message":"[Security
Solution] Remove 'Tech Preview' labels from EA workflows
(#156514)\n\nissue:
elastic/security-team#6544
Summary\r\n\r\n## Remove the `Technical Preview` label from the
following UI pages\r\n- [x] (Must Do) Entity Analytics dashboard
panels\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752482-90772171-99d4-4db1-b875-6fb3a00cd91e.png)\r\n\r\n-
[x] (Must Do) Alert
Flyout\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752377-e95c0c92-357b-4b5f-b03f-776457000b1f.png)\r\n\r\n-
[x] All Hosts/
Users\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752578-951241aa-1f1f-4693-99d0-636e2e53e449.png)\r\n\r\n-
[x] Host/ User
Details\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752661-4a03db27-94a0-451f-bf58-ef911573c5e1.png)\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235752854-46263685-7440-44db-9d3b-bb9177f55c6a.png)\r\n\r\n\r\n-
[x] Host/ Users
Flyout\r\n\r\n\r\n![Image](https://user-images.githubusercontent.com/82123779/235753556-256bb920-82f6-4129-8cdf-00a88286fc88.png)\r\n\r\n\r\n\r\n\r\n##
Retain the `Technical Preview` label in the following (No Changes):\r\n-
[x] Enablement workflow from the EA dashboard\r\n- [x] Information
message in flouts\r\n<img width=\"719\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/79533936/235903678-f982d483-7064-4172-ad1a-3a18b155c430.png\">","sha":"f5c12dc1b0aed3fa02a1bf141b58bac2968351cc"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants