Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove 'Tech Preview' labels from EA workflows #156514

Merged
merged 1 commit into from May 4, 2023
Merged

[Security Solution] Remove 'Tech Preview' labels from EA workflows #156514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ins/security_solution/public/common/components/event_details/cti_details/risk_summary.tsx
View file
Open in desktop
Expand Up @@ -48,6 +48,13 @@ const RiskSummaryComponent: React.FC<RiskEntity> = ({ risk, riskEntity, original
riskScoreEntity={riskEntity}
/>
}
toolTipTitle={
<RiskScoreHeaderTitle
title={i18n.RISK_DATA_TITLE(riskEntity)}
riskScoreEntity={riskEntity}
showTechnicalPreviewBadge
/>
}
toolTipContent={
<FormattedMessage
id="xpack.securitySolution.alertDetails.overview.riskDataTooltipContent"
Expand Down
5 changes: 3 additions & 2 deletions ...urity_solution/public/common/components/event_details/cti_details/threat_summary_view.tsx
View file
Open in desktop
Expand Up @@ -79,7 +79,8 @@ export const EnrichedDataRow: React.FC<{
export const ThreatSummaryPanelHeader: React.FC<{
title: string | React.ReactNode;
toolTipContent: React.ReactNode;
}> = ({ title, toolTipContent }) => {
toolTipTitle?: React.ReactNode;
}> = ({ title, toolTipContent, toolTipTitle }) => {
const [isPopoverOpen, setIsPopoverOpen] = useState(false);

const onClick = useCallback(() => {
Expand Down Expand Up @@ -111,7 +112,7 @@ export const ThreatSummaryPanelHeader: React.FC<{
/>
}
>
<EuiPopoverTitle>{title}</EuiPopoverTitle>
<EuiPopoverTitle>{toolTipTitle ?? title}</EuiPopoverTitle>
<EuiText size="s" style={{ width: '270px' }}>
{toolTipContent}
</EuiText>
Expand Down
5 changes: 4 additions & 1 deletion ...lugins/security_solution/public/explore/components/risk_score/enable_risk_score/index.tsx
View file
Open in desktop
Expand Up @@ -49,7 +49,10 @@ const EnableRiskScoreComponent = ({

return (
<EuiPanel hasBorder>
<HeaderSection title={<RiskScoreHeaderTitle riskScoreEntity={entityType} />} titleSize="s" />
<HeaderSection
title={<RiskScoreHeaderTitle riskScoreEntity={entityType} showTechnicalPreviewBadge />}
titleSize="s"
/>
<EuiEmptyPrompt
title={<h2>{text.cta}</h2>}
body={
Expand Down
6 changes: 5 additions & 1 deletion ...on/public/explore/components/risk_score/risk_score_onboarding/risk_score_header_title.tsx
View file
Open in desktop
Expand Up @@ -14,15 +14,19 @@ import { TECHNICAL_PREVIEW } from './translations';
const RiskScoreHeaderTitleComponent = ({
riskScoreEntity,
title,
showTechnicalPreviewBadge = false,
}: {
riskScoreEntity: RiskScoreEntity;
title?: string;
showTechnicalPreviewBadge?: boolean;
}) => {
return (
<>
{title ??
(riskScoreEntity === RiskScoreEntity.user ? i18n.USER_RISK_TITLE : i18n.HOST_RISK_TITLE)}
<NavItemBetaBadge text={TECHNICAL_PREVIEW} className="eui-alignMiddle" />
{showTechnicalPreviewBadge && (
<NavItemBetaBadge text={TECHNICAL_PREVIEW} className="eui-alignMiddle" />
)}
</>
);
};
Expand Down
14 changes: 0 additions & 14 deletions x-pack/plugins/security_solution/public/explore/hosts/pages/details/nav_tabs.test.tsx
View file
Open in desktop
Expand Up @@ -81,18 +81,4 @@ describe('navTabsHostDetails', () => {

expect(sessionsTab).not.toBeTruthy();
});

test('it should display Beta badge for risk tab', () => {
const tabs = navTabsHostDetails({
hasMlUserPermissions: false,
isRiskyHostsEnabled: true,
hostName: mockHostName,
});

const riskTab = Object.values<TabNavigationItemProps>(tabs).find(
(item) => item.id === HostsTableType.risk
);

expect(riskTab?.isBeta).toEqual(true);
});
});
5 changes: 0 additions & 5 deletions x-pack/plugins/security_solution/public/explore/hosts/pages/details/nav_tabs.tsx
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ import * as i18n from '../translations';
import type { HostDetailsNavTab } from './types';
import { HostsTableType } from '../../store/model';
import { HOSTS_PATH } from '../../../../../common/constants';
import { TECHNICAL_PREVIEW } from '../../../../overview/pages/translations';

const getTabsOnHostDetailsUrl = (hostName: string, tabName: HostsTableType) =>
`${HOSTS_PATH}/name/${hostName}/${tabName}`;
Expand Down Expand Up @@ -58,10 +57,6 @@ export const navTabsHostDetails = ({
name: i18n.NAVIGATION_HOST_RISK_TITLE,
href: getTabsOnHostDetailsUrl(hostName, HostsTableType.risk),
disabled: false,
isBeta: true,
betaOptions: {
text: TECHNICAL_PREVIEW,
},
},
[HostsTableType.sessions]: {
id: HostsTableType.sessions,
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/security_solution/public/explore/hosts/pages/nav_tabs.tsx
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ import * as i18n from './translations';
import { HostsTableType } from '../store/model';
import type { HostsNavTab } from './navigation/types';
import { HOSTS_PATH } from '../../../../common/constants';
import { TECHNICAL_PREVIEW } from '../../../overview/pages/translations';

const getTabsOnHostsUrl = (tabName: HostsTableType) => `${HOSTS_PATH}/${tabName}`;

Expand Down Expand Up @@ -54,10 +53,6 @@ export const navTabsHosts = ({
name: i18n.NAVIGATION_HOST_RISK_TITLE,
href: getTabsOnHostsUrl(HostsTableType.risk),
disabled: false,
isBeta: true,
betaOptions: {
text: TECHNICAL_PREVIEW,
},
},
[HostsTableType.sessions]: {
id: HostsTableType.sessions,
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/security_solution/public/explore/users/pages/details/nav_tabs.tsx
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ import * as i18n from '../translations';
import type { UsersDetailsNavTab } from './types';
import { UsersTableType } from '../../store/model';
import { USERS_PATH } from '../../../../../common/constants';
import { TECHNICAL_PREVIEW } from '../../../../overview/pages/translations';

const getTabsOnUsersDetailsUrl = (userName: string, tabName: UsersTableType) =>
`${USERS_PATH}/name/${userName}/${tabName}`;
Expand Down Expand Up @@ -46,10 +45,6 @@ export const navTabsUsersDetails = (
name: i18n.NAVIGATION_RISK_TITLE,
href: getTabsOnUsersDetailsUrl(userName, UsersTableType.risk),
disabled: false,
isBeta: true,
betaOptions: {
text: TECHNICAL_PREVIEW,
},
},
};

Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/security_solution/public/explore/users/pages/nav_tabs.tsx
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ import * as i18n from './translations';
import { UsersTableType } from '../store/model';
import type { UsersNavTab } from './navigation/types';
import { USERS_PATH } from '../../../../common/constants';
import { TECHNICAL_PREVIEW } from '../../../overview/pages/translations';

const getTabsOnUsersUrl = (tabName: UsersTableType) => `${USERS_PATH}/${tabName}`;

Expand Down Expand Up @@ -50,10 +49,6 @@ export const navTabsUsers = (
name: i18n.NAVIGATION_RISK_TITLE,
href: getTabsOnUsersUrl(UsersTableType.risk),
disabled: false,
isBeta: true,
betaOptions: {
text: TECHNICAL_PREVIEW,
},
},
};

Expand Down