[AIOps] Explain Log Rate Spikes: create shareable component containing only analysis #158629

alvarezmelissa87 · 2023-05-29T17:31:54Z

Summary

This PR exposes the ExplainLogRateSpikesContent shared component so that it can be used independently of the search bar/datepicker

The component accepts various external settings including a timerange and query to run the analysis against.
The ExplainLogRateSpikesPage component now uses the ExplainLogRateSpikesContent component
The useData hook has been simplified - the set up for the search query has been extracted into a separate hook

This is the first step for the Observability Alert Details Page Integration.

Style edits:

The component now uses EUI's ResizeableContainer to allow the main histogram to be sticky.
Also adds some style updates from #156605

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

elasticmachine · 2023-05-29T17:31:58Z

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87 · 2023-05-29T19:03:35Z

cc @benakansara

peteharverson · 2023-05-30T10:48:28Z

.../explain_log_rate_spikes/explain_log_rate_spikes_content/explain_log_rate_spikes_content.tsx

+            )}
+            <EuiHorizontalRule />
+          </EuiResizablePanel>
+          {/* <EuiResizableButton /> */}


Is this for a follow-up allowing the two panels to be resized?

Yes - just too much code churn to add in here 👍

peteharverson · 2023-05-30T10:55:20Z

.../explain_log_rate_spikes/explain_log_rate_spikes_content/explain_log_rate_spikes_content.tsx

+  }
+
+  return (
+    <EuiResizableContainer style={{ height: '400px' }} direction="vertical">


Do you have to specify a height here? Can it have a responsive layout so that it adapts to the available screen height?

peteharverson · 2023-05-30T11:10:31Z

.../explain_log_rate_spikes/explain_log_rate_spikes_content/explain_log_rate_spikes_content.tsx

+          <EuiResizablePanel
+            paddingSize="s"
+            mode={'main'}
+            initialSize={80}


Shouldn't the two values for initialSize add up to 100%?

peteharverson · 2023-05-30T11:13:15Z

.../explain_log_rate_spikes/explain_log_rate_spikes_content/explain_log_rate_spikes_content.tsx

+        <>
+          <EuiResizablePanel
+            mode={'collapsible'}
+            initialSize={60}


This panel is always getting a scrollbar for me. Does the initialSize or minSize need to be larger?

walterra

LGTM, pending fixed functional tests and fixing the scrollbar regression.

walterra · 2023-05-30T16:07:33Z

...plugins/aiops/public/components/explain_log_rate_spikes/explain_log_rate_spikes_analysis.tsx

+const resultsGroupedOffId = 'aiopsExplainLogRateSpikesGroupingOff';
+const resultsGroupedOnId = 'aiopsExplainLogRateSpikesGroupingOn';


Nit: Could be RESULTS_GROUPING_ID_OFF/ON as a const and to match the id a bit more.

peteharverson

LGTM. Re-enable the resizable panel layout in a follow-up PR.

kibana-ci · 2023-05-30T19:24:26Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 41bef2c

Failed CI Steps

FTR Configs #57

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	515	519	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	795.1KB	803.8KB	+8.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`aiops`	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`aiops`	6.0KB	6.2KB	+197.0B

Unknown metric groups

API count

id	before	after	diff
`aiops`	39	41	+2

async chunk count

id	before	after	diff
`aiops`	5	7	+2

ESLint disabled line counts

id	before	after	diff
`aiops`	24	23	-1
`enterpriseSearch`	19	21	+2
`securitySolution`	401	405	+4
total			+5

Total ESLint disabled count

id	before	after	diff
`aiops`	24	23	-1
`enterpriseSearch`	20	22	+2
`securitySolution`	481	485	+4
total			+5

History

💔 Build #131057 failed 1b057d9
💔 Build #130869 failed 38c7f01
💚 Build #130833 succeeded 9302f2c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

alvarezmelissa87 added release_note:enhancement :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.9.0 labels May 29, 2023

alvarezmelissa87 requested a review from walterra May 29, 2023 17:31

alvarezmelissa87 self-assigned this May 29, 2023

alvarezmelissa87 requested a review from a team as a code owner May 29, 2023 17:31

alvarezmelissa87 requested review from peteharverson and jgowdyelastic May 29, 2023 19:03

alvarezmelissa87 mentioned this pull request May 29, 2023

[ML] AIOps Log Rate Analysis: styling updates #156605

Open

14 tasks

alvarezmelissa87 added 2 commits May 29, 2023 17:53

create a shared component that only contains the analysis

932f989

Update styling for progress controls

38c7f01

alvarezmelissa87 force-pushed the aiops-for-observability branch from 16bb638 to 38c7f01 Compare May 29, 2023 23:53

peteharverson reviewed May 30, 2023

View reviewed changes

walterra approved these changes May 30, 2023

View reviewed changes

temp fix for scrolling issue

1b057d9

peteharverson approved these changes May 30, 2023

View reviewed changes

update functional tests

41bef2c

alvarezmelissa87 mentioned this pull request May 30, 2023

[AIOPS][Observability] Prototype - add Explain Log Rate Spikes UI to Alert details UI #158604

Draft

8 tasks

alvarezmelissa87 merged commit 03d4fe7 into elastic:main May 30, 2023

kibanamachine added the backport:skip This commit does not require backporting label May 30, 2023

alvarezmelissa87 deleted the aiops-for-observability branch May 30, 2023 19:45

peteharverson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Jun 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIOps] Explain Log Rate Spikes: create shareable component containing only analysis #158629

[AIOps] Explain Log Rate Spikes: create shareable component containing only analysis #158629

alvarezmelissa87 commented May 29, 2023 •

edited

Loading

elasticmachine commented May 29, 2023

alvarezmelissa87 commented May 29, 2023

peteharverson May 30, 2023

alvarezmelissa87 May 30, 2023

peteharverson May 30, 2023

peteharverson May 30, 2023

peteharverson May 30, 2023

walterra left a comment

walterra May 30, 2023

peteharverson left a comment

kibana-ci commented May 30, 2023

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

		const resultsGroupedOffId = 'aiopsExplainLogRateSpikesGroupingOff';
		const resultsGroupedOnId = 'aiopsExplainLogRateSpikesGroupingOn';

[AIOps] Explain Log Rate Spikes: create shareable component containing only analysis #158629

[AIOps] Explain Log Rate Spikes: create shareable component containing only analysis #158629

Conversation

alvarezmelissa87 commented May 29, 2023 • edited Loading

Summary

Checklist

elasticmachine commented May 29, 2023

alvarezmelissa87 commented May 29, 2023

peteharverson May 30, 2023

Choose a reason for hiding this comment

alvarezmelissa87 May 30, 2023

Choose a reason for hiding this comment

peteharverson May 30, 2023

Choose a reason for hiding this comment

peteharverson May 30, 2023

Choose a reason for hiding this comment

peteharverson May 30, 2023

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

walterra May 30, 2023

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

kibana-ci commented May 30, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

alvarezmelissa87 commented May 29, 2023 •

edited

Loading