display NOT when new filter is negated #15865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 9, 2018
nreese
added a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #15525 adds the ability to display an
Othersbucket for terms aggregations. When a user creates a filter onOthers, it is just a negate filter on the Top N terms.The
Apply these filtersUI does not provide any visual indication that a filter is negated and is a little confusing. This PR just addsNOTin front of a negated filter so users are presented with a better view of what the filter actually does.