[Lens] Make default dimension labels auto translate #159089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
stratoula
reviewed
Jun 22, 2023
src/plugins/data/common/search/aggs/buckets/lib/time_buckets/calc_es_interval.ts
Show resolved
Hide resolved
src/plugins/data/common/search/aggs/buckets/lib/time_buckets/calc_es_interval.ts
Show resolved
Hide resolved
src/plugins/data/common/search/aggs/buckets/lib/time_buckets/calc_es_interval.ts
Show resolved
Hide resolved
davismcphee
approved these changes
Jun 23, 2023
| moment.relativeTimeRounding(roundingDefault); | ||
|
|
||
| // restore all the default values now in moment to not break it | ||
| moment.updateLocale(moment.locale(), defaultLocaleConfig); |
There was a problem hiding this comment.
On the small chance there's an exception, I'd probably favour a try/finally on the locale modification to avoid accidentally modifying global state.
stratoula
approved these changes
Jun 23, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
mbondyra
approved these changes
Jun 23, 2023
stratoula
added
v8.10.0
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 23, 2023
## Summary Fixes elastic#147107 This PR fixes two issues with locale and default dimension labels: * generate default (non-custom) dimension labels at expression runtime rather than at dimension generation * make date histogram interval unit support locale Test notes: * create a dashboard with some panels with default labels, others with custom ones * then change the i18n configuration in the `kibana.yml` file and reload the dashboard * default labels + intervals should be now translated * custom labels should not change Here's a dashboard using all 4 editors with a date histogram charts. This PR is expected to have full effect on Lens and some effects on Agg-based visualization, no effects on Vega and TSVB: <img width="1508" alt="Screenshot 2023-06-06 at 10 21 03" src="https://github.com/elastic/kibana/assets/924948/812c7176-5a81-44bc-8619-7436a24fe608"> <img width="1507" alt="Screenshot 2023-06-06 at 10 19 01" src="https://github.com/elastic/kibana/assets/924948/34b8957d-eb07-48a6-8049-88b9e5e165e4"> <img width="1508" alt="Screenshot 2023-06-06 at 10 17 59" src="https://github.com/elastic/kibana/assets/924948/fde657fb-c9f7-4860-bc92-d4a3806fc16e"> <img width="1506" alt="Screenshot 2023-06-06 at 10 14 39" src="https://github.com/elastic/kibana/assets/924948/93c26f31-e98d-4985-a179-2c86e1ddb875"> ## Note <details> <summary>Previous issue with single unit</summary> There's a breaking change which affects the unit rate when it's a single value unit: <img width="1505" alt="Screenshot 2023-06-06 at 10 23 20" src="https://github.com/elastic/kibana/assets/924948/52eceaa5-78aa-4903-96be-8f33fd0360e9"> <img width="1509" alt="Screenshot 2023-06-06 at 10 22 34" src="https://github.com/elastic/kibana/assets/924948/f8625ec7-69c8-4b5d-ac87-50b9e56e282f"> The change is `timestamp per hour` to `timestamp per one hour`. ❌ It would be possible to handle few of these cases with manual parsing of the string for some languages (i.e. `durationDescription.split(' ')[1]`), but that is not a universal fix as it won't work for languages without spaces. TSVB "solves" reduces a lot this problem by stepping down the unit avoiding to use single value unit: `1 hour` => `60 minutes`. Perhaps a similar solution could be leveraged as well? I would still be some sort of major change. </details> The previous issue with single unit has been solved and will be completely visible once the i18n will be applied. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit 4265ad2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 26, 2023
…160357) # Backport This will backport the following commits from `main` to `8.9`: - [[Lens] Make default dimension labels auto translate (#159089)](#159089) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-23T07:53:27Z","message":"[Lens] Make default dimension labels auto translate (#159089)\n\n## Summary\r\n\r\nFixes #147107\r\n\r\nThis PR fixes two issues with locale and default dimension labels:\r\n* generate default (non-custom) dimension labels at expression runtime\r\nrather than at dimension generation\r\n* make date histogram interval unit support locale\r\n\r\nTest notes:\r\n* create a dashboard with some panels with default labels, others with\r\ncustom ones\r\n* then change the i18n configuration in the `kibana.yml` file and reload\r\nthe dashboard\r\n * default labels + intervals should be now translated\r\n * custom labels should not change\r\n\r\nHere's a dashboard using all 4 editors with a date histogram charts.\r\nThis PR is expected to have full effect on Lens and some effects on\r\nAgg-based visualization, no effects on Vega and TSVB:\r\n\r\n<img width=\"1508\" alt=\"Screenshot 2023-06-06 at 10 21 03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/812c7176-5a81-44bc-8619-7436a24fe608\">\r\n<img width=\"1507\" alt=\"Screenshot 2023-06-06 at 10 19 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/34b8957d-eb07-48a6-8049-88b9e5e165e4\">\r\n<img width=\"1508\" alt=\"Screenshot 2023-06-06 at 10 17 59\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/fde657fb-c9f7-4860-bc92-d4a3806fc16e\">\r\n<img width=\"1506\" alt=\"Screenshot 2023-06-06 at 10 14 39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/93c26f31-e98d-4985-a179-2c86e1ddb875\">\r\n\r\n## Note\r\n\r\n<details>\r\n <summary>Previous issue with single unit</summary>\r\n\r\nThere's a breaking change which affects the unit rate when it's a single\r\nvalue unit:\r\n<img width=\"1505\" alt=\"Screenshot 2023-06-06 at 10 23 20\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/52eceaa5-78aa-4903-96be-8f33fd0360e9\">\r\n<img width=\"1509\" alt=\"Screenshot 2023-06-06 at 10 22 34\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/f8625ec7-69c8-4b5d-ac87-50b9e56e282f\">\r\n\r\nThe change is `timestamp per hour` to `timestamp per one hour`. ❌ \r\nIt would be possible to handle few of these cases with manual parsing of\r\nthe string for some languages (i.e. `durationDescription.split('\r\n')[1]`), but that is not a universal fix as it won't work for languages\r\nwithout spaces.\r\n\r\nTSVB \"solves\" reduces a lot this problem by stepping down the unit\r\navoiding to use single value unit: `1 hour` => `60 minutes`. Perhaps a\r\nsimilar solution could be leveraged as well? I would still be some sort\r\nof major change.\r\n</details>\r\n\r\nThe previous issue with single unit has been solved and will be\r\ncompletely visible once the i18n will be applied.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"4265ad2beab99b76dff3da7c54f0b0e7370e3a4b","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.9.0","v8.10.0"],"number":159089,"url":"#159089 Make default dimension labels auto translate (#159089)\n\n## Summary\r\n\r\nFixes #147107\r\n\r\nThis PR fixes two issues with locale and default dimension labels:\r\n* generate default (non-custom) dimension labels at expression runtime\r\nrather than at dimension generation\r\n* make date histogram interval unit support locale\r\n\r\nTest notes:\r\n* create a dashboard with some panels with default labels, others with\r\ncustom ones\r\n* then change the i18n configuration in the `kibana.yml` file and reload\r\nthe dashboard\r\n * default labels + intervals should be now translated\r\n * custom labels should not change\r\n\r\nHere's a dashboard using all 4 editors with a date histogram charts.\r\nThis PR is expected to have full effect on Lens and some effects on\r\nAgg-based visualization, no effects on Vega and TSVB:\r\n\r\n<img width=\"1508\" alt=\"Screenshot 2023-06-06 at 10 21 03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/812c7176-5a81-44bc-8619-7436a24fe608\">\r\n<img width=\"1507\" alt=\"Screenshot 2023-06-06 at 10 19 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/34b8957d-eb07-48a6-8049-88b9e5e165e4\">\r\n<img width=\"1508\" alt=\"Screenshot 2023-06-06 at 10 17 59\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/fde657fb-c9f7-4860-bc92-d4a3806fc16e\">\r\n<img width=\"1506\" alt=\"Screenshot 2023-06-06 at 10 14 39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/93c26f31-e98d-4985-a179-2c86e1ddb875\">\r\n\r\n## Note\r\n\r\n<details>\r\n <summary>Previous issue with single unit</summary>\r\n\r\nThere's a breaking change which affects the unit rate when it's a single\r\nvalue unit:\r\n<img width=\"1505\" alt=\"Screenshot 2023-06-06 at 10 23 20\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/52eceaa5-78aa-4903-96be-8f33fd0360e9\">\r\n<img width=\"1509\" alt=\"Screenshot 2023-06-06 at 10 22 34\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/f8625ec7-69c8-4b5d-ac87-50b9e56e282f\">\r\n\r\nThe change is `timestamp per hour` to `timestamp per one hour`. ❌ \r\nIt would be possible to handle few of these cases with manual parsing of\r\nthe string for some languages (i.e. `durationDescription.split('\r\n')[1]`), but that is not a universal fix as it won't work for languages\r\nwithout spaces.\r\n\r\nTSVB \"solves\" reduces a lot this problem by stepping down the unit\r\navoiding to use single value unit: `1 hour` => `60 minutes`. Perhaps a\r\nsimilar solution could be leveraged as well? I would still be some sort\r\nof major change.\r\n</details>\r\n\r\nThe previous issue with single unit has been solved and will be\r\ncompletely visible once the i18n will be applied.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"4265ad2beab99b76dff3da7c54f0b0e7370e3a4b"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#159089 Make default dimension labels auto translate (#159089)\n\n## Summary\r\n\r\nFixes #147107\r\n\r\nThis PR fixes two issues with locale and default dimension labels:\r\n* generate default (non-custom) dimension labels at expression runtime\r\nrather than at dimension generation\r\n* make date histogram interval unit support locale\r\n\r\nTest notes:\r\n* create a dashboard with some panels with default labels, others with\r\ncustom ones\r\n* then change the i18n configuration in the `kibana.yml` file and reload\r\nthe dashboard\r\n * default labels + intervals should be now translated\r\n * custom labels should not change\r\n\r\nHere's a dashboard using all 4 editors with a date histogram charts.\r\nThis PR is expected to have full effect on Lens and some effects on\r\nAgg-based visualization, no effects on Vega and TSVB:\r\n\r\n<img width=\"1508\" alt=\"Screenshot 2023-06-06 at 10 21 03\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/812c7176-5a81-44bc-8619-7436a24fe608\">\r\n<img width=\"1507\" alt=\"Screenshot 2023-06-06 at 10 19 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/34b8957d-eb07-48a6-8049-88b9e5e165e4\">\r\n<img width=\"1508\" alt=\"Screenshot 2023-06-06 at 10 17 59\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/fde657fb-c9f7-4860-bc92-d4a3806fc16e\">\r\n<img width=\"1506\" alt=\"Screenshot 2023-06-06 at 10 14 39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/93c26f31-e98d-4985-a179-2c86e1ddb875\">\r\n\r\n## Note\r\n\r\n<details>\r\n <summary>Previous issue with single unit</summary>\r\n\r\nThere's a breaking change which affects the unit rate when it's a single\r\nvalue unit:\r\n<img width=\"1505\" alt=\"Screenshot 2023-06-06 at 10 23 20\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/52eceaa5-78aa-4903-96be-8f33fd0360e9\">\r\n<img width=\"1509\" alt=\"Screenshot 2023-06-06 at 10 22 34\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/f8625ec7-69c8-4b5d-ac87-50b9e56e282f\">\r\n\r\nThe change is `timestamp per hour` to `timestamp per one hour`. ❌ \r\nIt would be possible to handle few of these cases with manual parsing of\r\nthe string for some languages (i.e. `durationDescription.split('\r\n')[1]`), but that is not a universal fix as it won't work for languages\r\nwithout spaces.\r\n\r\nTSVB \"solves\" reduces a lot this problem by stepping down the unit\r\navoiding to use single value unit: `1 hour` => `60 minutes`. Perhaps a\r\nsimilar solution could be leveraged as well? I would still be some sort\r\nof major change.\r\n</details>\r\n\r\nThe previous issue with single unit has been solved and will be\r\ncompletely visible once the i18n will be applied.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"4265ad2beab99b76dff3da7c54f0b0e7370e3a4b"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #147107
This PR fixes two issues with locale and default dimension labels:
Test notes:
kibana.ymlfile and reload the dashboardHere's a dashboard using all 4 editors with a date histogram charts.
This PR is expected to have full effect on Lens and some effects on Agg-based visualization, no effects on Vega and TSVB:
Note
Previous issue with single unit
There's a breaking change which affects the unit rate when it's a single value unit:
The change is
timestamp per hourtotimestamp per one hour. ❌It would be possible to handle few of these cases with manual parsing of the string for some languages (i.e.
durationDescription.split(' ')[1]), but that is not a universal fix as it won't work for languages without spaces.TSVB "solves" reduces a lot this problem by stepping down the unit avoiding to use single value unit:
1 hour=>60 minutes. Perhaps a similar solution could be leveraged as well? I would still be some sort of major change.The previous issue with single unit has been solved and will be completely visible once the i18n will be applied.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers