Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Lens] Make default dimension labels auto translate (elastic#159089)
## Summary Fixes elastic#147107 This PR fixes two issues with locale and default dimension labels: * generate default (non-custom) dimension labels at expression runtime rather than at dimension generation * make date histogram interval unit support locale Test notes: * create a dashboard with some panels with default labels, others with custom ones * then change the i18n configuration in the `kibana.yml` file and reload the dashboard * default labels + intervals should be now translated * custom labels should not change Here's a dashboard using all 4 editors with a date histogram charts. This PR is expected to have full effect on Lens and some effects on Agg-based visualization, no effects on Vega and TSVB: <img width="1508" alt="Screenshot 2023-06-06 at 10 21 03" src="https://github.com/elastic/kibana/assets/924948/812c7176-5a81-44bc-8619-7436a24fe608"> <img width="1507" alt="Screenshot 2023-06-06 at 10 19 01" src="https://github.com/elastic/kibana/assets/924948/34b8957d-eb07-48a6-8049-88b9e5e165e4"> <img width="1508" alt="Screenshot 2023-06-06 at 10 17 59" src="https://github.com/elastic/kibana/assets/924948/fde657fb-c9f7-4860-bc92-d4a3806fc16e"> <img width="1506" alt="Screenshot 2023-06-06 at 10 14 39" src="https://github.com/elastic/kibana/assets/924948/93c26f31-e98d-4985-a179-2c86e1ddb875"> ## Note <details> <summary>Previous issue with single unit</summary> There's a breaking change which affects the unit rate when it's a single value unit: <img width="1505" alt="Screenshot 2023-06-06 at 10 23 20" src="https://github.com/elastic/kibana/assets/924948/52eceaa5-78aa-4903-96be-8f33fd0360e9"> <img width="1509" alt="Screenshot 2023-06-06 at 10 22 34" src="https://github.com/elastic/kibana/assets/924948/f8625ec7-69c8-4b5d-ac87-50b9e56e282f"> The change is `timestamp per hour` to `timestamp per one hour`. ❌ It would be possible to handle few of these cases with manual parsing of the string for some languages (i.e. `durationDescription.split(' ')[1]`), but that is not a universal fix as it won't work for languages without spaces. TSVB "solves" reduces a lot this problem by stepping down the unit avoiding to use single value unit: `1 hour` => `60 minutes`. Perhaps a similar solution could be leveraged as well? I would still be some sort of major change. </details> The previous issue with single unit has been solved and will be completely visible once the i18n will be applied. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit 4265ad2)
- Loading branch information
