Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Adds secondary sort by doc_count only if sorted by p-value #159568

Merged
merged 6 commits into from
Jun 15, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jun 13, 2023

Summary

Part of #156011.

Adds a secondary sort by doc_count only if the results table is sorted by p-value. This is useful in cases when there are lots of items with the same p-value. The combination of high significance (low p-value) and sorted by doc_count ascending will surface the most unique field/value combinations.

Before:

image

After:

image

Checklist

@walterra walterra self-assigned this Jun 13, 2023
@walterra walterra marked this pull request as ready for review June 13, 2023 13:10
@walterra walterra requested a review from a team as a code owner June 13, 2023 13:10
@walterra walterra added :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.9.0 labels Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 804.9KB 805.2KB +310.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 493 497 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 632424e into elastic:main Jun 15, 2023
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 15, 2023
@walterra walterra deleted the ml-aiops-secondary-sort branch June 15, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants