[Integrate Profiling with APM] Navigate from the transaction details view into the Profiling

[cauemarcondes]

• The new profiling items will be only visible when the profiling plugin has been already installed. Otherwise, these are going to be hidden.
• The profiling plugin exposes three new Locators to facilitate the navigation to the Flamegraph, TopN functions and Stacktraces pages.
• Add new badge property on the section component

Screen.Recording.2023-06-14.at.1.06.42.PM.mov

Screen.Recording.2023-06-14.at.1.06.19.PM.mov

flamegraph.mov

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[formgeist]

@cauemarcondes I think there's been some slight degradations on the Investigate links, since they appear massive right now. Can we please reduce the size of the links and changing the style to primary?

Here's the changes to the default props to the EuiListGroup component as applied in the Investigate menu.

export function SectionLinks({ children, ...props }: { children?: ReactNode } & EuiListGroupProps) {
  return (
    <EuiListGroup {...props} size={'s'} color={'primary'} flush={true} bordered={false}>
      {children}
    </EuiListGroup>
  );
}

[cauemarcondes]

@formgeist I updated the description with the changes you suggested. Thanks for that.

[gbamparop]

APM changes LGTM!

[gbamparop]

cc @boriskirov

[Ikuni17]

limits.yml

[thomasdullien]

LGTM :)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: bd48a5d

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
apm	1460	1461	+1
profiling	166	169	+3
total			+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
profiling	16	19	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	3.6MB	3.6MB	+1.3KB
profiling	294.9KB	289.7KB	-5.2KB
total			-3.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
profiling	0	3	+3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
observabilityShared	41.6KB	41.9KB	+358.0B
profiling	14.6KB	21.1KB	+6.5KB
total			+6.8KB

Unknown metric groups

API count

id	before	after	diff
profiling	16	19	+3

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	489	493	+4
total			+6

History

• 💚 Build #140072 succeeded 1f1b1e5
• 💚 Build #139770 succeeded b13a9f8
• 💛 Build #138756 was flaky bb88a81
• 💛 Build #138025 was flaky 28e9a6f
• 💔 Build #137966 failed 5c5b105
• 💔 Build #137264 failed 4f1d2c2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jasonrhodes]

I've added some questions/concerns about dependency introductions.

[jasonrhodes]

I like locators as an abstraction. I don't like how they introduce dependencies between observability apps (what happens if profiling wants to link to APM?).

Should we introduce a pattern for keeping locators in "observability-shared", separated by folders that could still be managed via our standard codeowners?

[cauemarcondes]

Thanks for raising this up. Let me see what I can move to the observability-shared.

[jasonrhodes]

I don't want to unnecessarily hold this feature up to solve this, so if we need to address this outside of this PR, that's fine. But we should talk about what this pattern should look like. APM already depends on the "infra" plugin and uses its locators (#158365) but the APM -> Infra plugin dependency causes lots of problems for us overall, imo.

[jasonrhodes]

My biggest worry is that the introduction of this dependency would lead us to start pulling other things in, and making it harder to disconnect that dependency in the future, which is the future I want us to aim for (no deps between obs UI plugins). I have a plan for how we might get around this, stay tuned.

[jasonrhodes]

We're likely going to want this exact thing in the Hosts UI view (cc: @neptunian) -- I don't want to abstract too early so we can copy/paste at first, but eventually we should consider whether it makes sense to have an ObservabilityContext we all share/use/load. I imagine that would need to live in the observability-shared plugin (similar to my comment about locators).

[jasonrhodes]

Caue and I talked a bit about the APM -> Profiling dependency and decided it's not something we should block this PR for, but that we should sync up ASAP and create an issue to see if we can find a way to remove that dependency by leveraging the observability_shared plugin in a couple different ways.