Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integrate Profiling with APM] Navigate from the transaction details view into the Profiling #159686
[Integrate Profiling with APM] Navigate from the transaction details view into the Profiling #159686
Changes from 19 commits
6146dab
6e2fcef
c795d0b
6895153
54f892c
761d447
ecdeb75
51b8bec
018a317
e9dc339
84880c8
5508b55
0d5b05d
5368b4a
ed5de2e
4f1d2c2
5c5b105
1bb2575
28e9a6f
bb88a81
b13a9f8
1f1b1e5
bd48a5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're likely going to want this exact thing in the Hosts UI view (cc: @neptunian) -- I don't want to abstract too early so we can copy/paste at first, but eventually we should consider whether it makes sense to have an ObservabilityContext we all share/use/load. I imagine that would need to live in the observability-shared plugin (similar to my comment about locators).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like locators as an abstraction. I don't like how they introduce dependencies between observability apps (what happens if profiling wants to link to APM?).
Should we introduce a pattern for keeping locators in "observability-shared", separated by folders that could still be managed via our standard codeowners?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this up. Let me see what I can move to the
observability-shared
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to unnecessarily hold this feature up to solve this, so if we need to address this outside of this PR, that's fine. But we should talk about what this pattern should look like. APM already depends on the "infra" plugin and uses its locators (#158365) but the APM -> Infra plugin dependency causes lots of problems for us overall, imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My biggest worry is that the introduction of this dependency would lead us to start pulling other things in, and making it harder to disconnect that dependency in the future, which is the future I want us to aim for (no deps between obs UI plugins). I have a plan for how we might get around this, stay tuned.