[Fleet][Agent Tampering] Remove unused created_at field from uninstall token SO mapping
#159985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergoabraham
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
juliaElastic
approved these changes
Jun 20, 2023
rudolf
approved these changes
Jun 20, 2023
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
1 task
gergoabraham
deleted the
task/fleet-agent-tampering-remove-unused-field-from-unreleased-saved-object-mapping
branch
gergoabraham
added a commit
that referenced
this pull request
Jun 30, 2023
…159944) ## Summary > **Note** > For testing: enable the `agentTamperProtectionEnabled` feature flag. This PR modifies the quite new `GET /api/fleet/uninstall_tokens` API: - `GET /api/fleet/uninstall_tokens`, returns token 'metadata' (i.e. **uninstall token id**, policy ID and creation date) for the latest token for every policy, without the token itself. - it is paginated (query params `page`, `perPage`), - and can be searched by partial policy ID (query param `policyId`). - this route is not used at the moment, will be used very soon - `GET /api/fleet/uninstall_tokens/{id}` returns one decrypted token identified by its ID - ~`GET /api/fleet/agent_policies/{policyId}/uninstall_tokens`, returns the decrypted token history for one policy~ - ~this route is used by the `UninstallCommandFlyout`~ - this was added and then removed, because not a necessity at the moment, and let's keep open all doors for agent tampering v2 ### Todo - done ✅ `created_at` field was removed from the uninstall token saved object mapping (21855ce), because it was unused and messed up ordering by the saved object's own `created_at` field. This removal is not allowed, though, so this issue needs to be fixed. **Update:** after a discussion with Kibana Core team, the `created_at` field was removed in a separate PR which is merged in v8.9.0. Reason: it's okay to use the SO's internal `created_at` field for sorting. Also, the mapping will be released in v8.9.0 first, so it's okay to modify it this time. The PR: #159985 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
created_atfield was added to the mapping for the uninstall token Saved Object, but it's not used and causes trouble.There is a discussion whether to remove it from the mapping or not, before the recently added mapping itself is released with v8.9.0, so I prepared this PR to merge in case we want to remove it.The discussion ended with the decision to remove the field, so the aim is to merge this PR.