Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix links to dashboards in Lens created anomaly detection jobs #160156

Merged
merged 5 commits into from
Jun 22, 2023
Merged

[ML] Fix links to dashboards in Lens created anomaly detection jobs #160156

merged 5 commits into from
Jun 22, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jun 21, 2023 •
edited by kibanamachine
Loading

When creating a job from a Lens visualisation, a link back to the original dashboard is added to the job's custom URLs.
This has recently become broken due to the dashboard ID retrieved from the lens embeddable not matching the real dashboard ID.
Rather than rely on this ID, the actual dashboard is retrieved from kibana using the dashboard service and the ID acquired from there.

The dashboard service also contains the dashboard url locator which we can use rather than use the share plugin.

@jgowdyelastic jgowdyelastic self-assigned this Jun 21, 2023
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner June 21, 2023 15:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +9.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and other than the typo, LGTM!

x-pack/plugins/ml/public/application/jobs/new_job/job_from_dashboard/quick_create_job_base.ts
// embeddable may have not been in a dashboard
// and my not have been given a title as it is unsaved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo - may instead of my

alvarezmelissa87
alvarezmelissa87 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit cf92a67 into elastic:main Jun 22, 2023
@jgowdyelastic jgowdyelastic deleted the fixes-link-to-dashbaord-in-lens-created-ad-jobs branch June 22, 2023 20:03
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2023
Open
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2023
@jgowdyelastic
[ML] Fix links to dashboards in Lens created anomaly detection jobs (e…
2df2c7f 
…lastic#160156)

When creating a job from a Lens visualisation, a link back to the
original dashboard is added to the job's custom URLs.
This has recently become broken due to the dashboard ID retrieved from
the lens embeddable not matching the real dashboard ID.
Rather than rely on this ID, the actual dashboard is retrieved from
kibana using the dashboard service and the ID acquired from there.

The dashboard service also contains the dashboard url locator which we
can use rather than use the `share` plugin.

(cherry picked from commit cf92a67)
@kibanamachine kibanamachine mentioned this pull request Jun 23, 2023
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 4, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @alvarezmelissa87 @peteharverson