[ML] Hide inference stats for PyTorch models #160599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Feature:3rd Party Models
|
Pinging @elastic/ml-ui (:ml) |
| ]); | ||
|
|
||
| const initialSelectedTab = | ||
| item.state === 'started' ? tabs.find((t) => t.id === 'stats') : tabs[0]; |
There was a problem hiding this comment.
Suggested change
| item.state === 'started' ? tabs.find((t) => t.id === 'stats') : tabs[0]; | |
| item.state === DEPLOYMENT_STATE.STARTED ? tabs.find((t) => t.id === 'stats') : tabs[0]; |
There was a problem hiding this comment.
@jgowdyelastic I wonder if it is actually worth an extra import? It's type-safe already and in case we want to rename it one day, it's going to be easy because the value is derived from a type definition.
There was a problem hiding this comment.
I think the types aren't quite correct for this, when I opened it in an editor item.state had an any type on this line.
But yeah, if the state type can be corrected, not adding the constant to the file makes sense.
There was a problem hiding this comment.
just checked and the issue is the MODEL_STATE dictionary that contains i18n strings. I guess I need to separate string literals and the actual translation.
There was a problem hiding this comment.
@jgowdyelastic fixed it by making it a regular string literal. There is no need for translation because other deployment state values come from the ML backend and are not translated at the moment.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @darnautov |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
rshen91
pushed a commit
that referenced
this pull request
Jun 28, 2023
## Summary Resolves #157385 Hides inference stats for the PyTorch models. - The salient information (`inference_count`, `timestamp`) is a repeat of what is already displayed in the Deployment Stats section. - `missing_all_fields_count` is confusing as the PyTorch models take a single input field rather than multiple fields as DFA models do, hence omitted. - The deployment stats have an [error_count](https://www.elastic.co/guide/en/elasticsearch/reference/current/get-trained-models-stats.html) field, hence it has been added to the Deployment Stats and `failure_count` has been removed. - Displays the stats tab by default for expanded rows if the model has started deployments
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jun 29, 2023
## Summary Resolves elastic#157385 Hides inference stats for the PyTorch models. - The salient information (`inference_count`, `timestamp`) is a repeat of what is already displayed in the Deployment Stats section. - `missing_all_fields_count` is confusing as the PyTorch models take a single input field rather than multiple fields as DFA models do, hence omitted. - The deployment stats have an [error_count](https://www.elastic.co/guide/en/elasticsearch/reference/current/get-trained-models-stats.html) field, hence it has been added to the Deployment Stats and `failure_count` has been removed. - Displays the stats tab by default for expanded rows if the model has started deployments (cherry picked from commit 4064e2b) # Conflicts: # x-pack/plugins/ml/public/application/model_management/expanded_row.tsx
darnautov
added a commit
that referenced
this pull request
Jun 29, 2023
# Backport This will backport the following commits from `main` to `8.9`: - [[ML] Hide inference stats for PyTorch models (#160599)](#160599) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-06-28T12:55:28Z","message":"[ML] Hide inference stats for PyTorch models (#160599)\n\n## Summary\r\n\r\nResolves #157385 inference stats for the PyTorch models. \r\n\r\n- The salient information (`inference_count`, `timestamp`) is a repeat\r\nof what is already displayed in the Deployment Stats section.\r\n- `missing_all_fields_count` is confusing as the PyTorch models take a\r\nsingle input field rather than multiple fields as DFA models do, hence\r\nomitted.\r\n- The deployment stats have an\r\n[error_count](https://www.elastic.co/guide/en/elasticsearch/reference/current/get-trained-models-stats.html)\r\nfield, hence it has been added to the Deployment Stats and\r\n`failure_count` has been removed.\r\n- Displays the stats tab by default for expanded rows if the model has\r\nstarted deployments","sha":"4064e2b7d4ea4a9a0c034d8450808f1a542ac0dd","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:3rd Party Models","Team:ML","v8.9.0","v8.10.0"],"number":160599,"url":"#160599 Hide inference stats for PyTorch models (#160599)\n\n## Summary\r\n\r\nResolves #157385 inference stats for the PyTorch models. \r\n\r\n- The salient information (`inference_count`, `timestamp`) is a repeat\r\nof what is already displayed in the Deployment Stats section.\r\n- `missing_all_fields_count` is confusing as the PyTorch models take a\r\nsingle input field rather than multiple fields as DFA models do, hence\r\nomitted.\r\n- The deployment stats have an\r\n[error_count](https://www.elastic.co/guide/en/elasticsearch/reference/current/get-trained-models-stats.html)\r\nfield, hence it has been added to the Deployment Stats and\r\n`failure_count` has been removed.\r\n- Displays the stats tab by default for expanded rows if the model has\r\nstarted deployments","sha":"4064e2b7d4ea4a9a0c034d8450808f1a542ac0dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#160599 Hide inference stats for PyTorch models (#160599)\n\n## Summary\r\n\r\nResolves #157385 inference stats for the PyTorch models. \r\n\r\n- The salient information (`inference_count`, `timestamp`) is a repeat\r\nof what is already displayed in the Deployment Stats section.\r\n- `missing_all_fields_count` is confusing as the PyTorch models take a\r\nsingle input field rather than multiple fields as DFA models do, hence\r\nomitted.\r\n- The deployment stats have an\r\n[error_count](https://www.elastic.co/guide/en/elasticsearch/reference/current/get-trained-models-stats.html)\r\nfield, hence it has been added to the Deployment Stats and\r\n`failure_count` has been removed.\r\n- Displays the stats tab by default for expanded rows if the model has\r\nstarted deployments","sha":"4064e2b7d4ea4a9a0c034d8450808f1a542ac0dd"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #157385
Hides inference stats for the PyTorch models.
inference_count,timestamp) is a repeat of what is already displayed in the Deployment Stats section.missing_all_fields_countis confusing as the PyTorch models take a single input field rather than multiple fields as DFA models do, hence omitted.failure_counthas been removed.