Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Hide inference stats for PyTorch models #160599

Merged
merged 5 commits into from Jun 28, 2023
Merged

[ML] Hide inference stats for PyTorch models #160599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31a51bf
hide inference stats for pytorch models
darnautov Jun 27, 2023
648fd2c
error count column
darnautov Jun 27, 2023
97006bf
show stats tab by default for started models
darnautov Jun 27, 2023
961205f
string literal for the model state
darnautov Jun 28, 2023
04443d5
fix type
darnautov Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions x-pack/packages/ml/trained_models_utils/src/constants/trained_models.ts
View file
Open in desktop
Expand Up @@ -61,12 +61,8 @@ export const ELASTIC_MODEL_DEFINITIONS = {

export const MODEL_STATE = {
...DEPLOYMENT_STATE,
DOWNLOADING: i18n.translate('xpack.ml.trainedModels.modelsList.downloadingStateLabel', {
defaultMessage: 'downloading',
}),
DOWNLOADED: i18n.translate('xpack.ml.trainedModels.modelsList.downloadedStateLabel', {
defaultMessage: 'downloaded',
}),
DOWNLOADING: 'downloading',
DOWNLOADED: 'downloaded',
} as const;

export type ModelState = typeof MODEL_STATE[keyof typeof MODEL_STATE];
export type ModelState = typeof MODEL_STATE[keyof typeof MODEL_STATE] | null;
1 change: 1 addition & 0 deletions x-pack/plugins/ml/common/types/trained_models.ts
View file
Open in desktop
Expand Up @@ -202,6 +202,7 @@ export interface AllocatedModel {
throughput_last_minute: number;
number_of_allocations: number;
threads_per_allocation: number;
error_count?: number;
};
}

Expand Down
10 changes: 10 additions & 0 deletions x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx
View file
Open in desktop
Expand Up @@ -220,6 +220,16 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
return v.node.number_of_pending_requests;
},
},
{
name: i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.errorCountHeader', {
defaultMessage: 'Errors',
}),
width: '60px',
'data-test-subj': 'mlAllocatedModelsTableErrorCount',
render: (v: AllocatedModel) => {
return v.node.error_count ?? 0;
},
},
].filter((v) => !hideColumns.includes(v.id!));

return (
Expand Down