[RAM] Use AAD When Running Action #161213

jcger · 2023-07-04T16:55:31Z

Summary

Feature can be activated via feature flag:
xpack.trigger_actions_ui.enableExperimental: ['isMustacheAutocompleteOn', 'showMustacheAutocompleteSwitch']

…handler-refactor

x-pack/plugins/alerting/server/task_runner/execution_handler.ts

…n-handler-refactor

jcger · 2023-09-20T15:43:18Z

x-pack/plugins/monitoring/public/alerts/alert_form.test.tsx

-                producerId="alerting"
-              />
-            </KibanaReactContext.Provider>
+            <QueryClientProvider client={queryClient}>


Looks like the plugin isn't importing the ActionForm but just this test so we will keep React Query as it is

…fix'

…kibana into 158183-execution-handler-refactor

…handler-refactor

…kibana into 158183-execution-handler-refactor

…handler-refactor

kibana-ci · 2023-09-26T09:36:52Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] Investigations - Security Solution Cypress Tests #6 / Detections : Page Filters Impact of inputs "after each" hook for "should take timeRange into account" "after each" hook for "should take timeRange into account"
[job] [logs] Investigations - Security Solution Cypress Tests #6 / Detections : Page Filters Impact of inputs should take timeRange into account should take timeRange into account
[job] [logs] FTR Configs #8 / Discover alerting Search source Alert "after all" hook for "should check that there are no errors detected after an alert is created"
[job] [logs] FTR Configs #8 / Discover alerting Search source Alert "after all" hook for "should check that there are no errors detected after an alert is created"
[job] [logs] FTR Configs #8 / Discover alerting Search source Alert should show time field validation error
[job] [logs] FTR Configs #8 / Discover alerting Search source Alert should show time field validation error
[job] [logs] FTR Configs #58 / serverless common UI Index Management Indices "before all" hook for "renders the indices tab"
[job] [logs] FTR Configs #58 / serverless observability UI landing page "before all" hook for "has quickstart badge"
[job] [logs] FTR Configs #33 / serverless security UI landing page "before all" hook for "has serverless side nav"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`stackConnectors`	239	206	-33
`triggersActionsUi`	586	591	+5
total			-28

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`alerting`	741	742	+1
`triggersActionsUi`	551	553	+2
total			+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`stackConnectors`	467.0KB	449.3KB	-17.7KB
`triggersActionsUi`	1.4MB	1.4MB	+1.7KB
total			-16.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	36.5KB	36.2KB	-326.0B
`triggersActionsUi`	92.0KB	98.6KB	+6.6KB
total			+6.3KB

Unknown metric groups

API count

id	before	after	diff
`alerting`	772	773	+1
`triggersActionsUi`	577	579	+2
total			+3

ESLint disabled line counts

id	before	after	diff
`stackConnectors`	94	93	-1
`triggersActionsUi`	124	125	+1
total			-0

Total ESLint disabled count

id	before	after	diff
`stackConnectors`	99	98	-1
`triggersActionsUi`	130	131	+1
total			-0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mdefazio · 2023-10-17T12:56:26Z

@jcger @XavierM Perhaps a repeated question, so apologies upfront.

What is our reasoning for putting this inside the action? And not above all actions? Assuming I will need to toggle this for every action I add?

~~Had we previously discussed placing this within the variables popover? Was there a reason not to do this?~~ Update: Realizing now why this is not a good idea...

mdefazio · 2023-10-17T16:22:03Z

@lcawl Would you mind taking a look at this copy? (And I didn't know if we should provide an example of how to access these fields...and what that example looks like)

cc/ @XavierM

Zacqary · 2023-10-25T19:03:29Z

Picking this up. TODO:

Add tests
Save the previous template message in memory when the user toggles on AAD mode
Investigate how many stack connectors use multiple message variables, and ensure they're all toggling correctly (e.g. Subject line and message body for email, Jira summary and message, ServiceNow summary and message)

Zacqary · 2023-10-30T17:28:27Z

Closing in favor of #170162

## Summary Reopen of #161213 Closes #160838 Feature can be activated via feature flag: `xpack.trigger_actions_ui.enableExperimental: ['isMustacheAutocompleteOn', 'showMustacheAutocompleteSwitch']` <img width="605" alt="Screenshot 2023-10-30 at 5 52 39 PM" src="https://github.com/elastic/kibana/assets/1445834/da24b419-3b08-4014-be2f-99692773755f"> <img width="583" alt="Screenshot 2023-10-30 at 5 52 22 PM" src="https://github.com/elastic/kibana/assets/1445834/fc5b8a1e-8202-4491-b4fb-694b70809f4d"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

## Summary Reopen of elastic#161213 Closes elastic#160838 Feature can be activated via feature flag: `xpack.trigger_actions_ui.enableExperimental: ['isMustacheAutocompleteOn', 'showMustacheAutocompleteSwitch']` <img width="605" alt="Screenshot 2023-10-30 at 5 52 39 PM" src="https://github.com/elastic/kibana/assets/1445834/da24b419-3b08-4014-be2f-99692773755f"> <img width="583" alt="Screenshot 2023-10-30 at 5 52 22 PM" src="https://github.com/elastic/kibana/assets/1445834/fc5b8a1e-8202-4491-b4fb-694b70809f4d"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

first commit

0bd9cc7

jcger added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0 labels Jul 4, 2023

Merge branch 'main' of github.com:jcger/kibana into 158183-execution-…

18f6b19

…handler-refactor

jcger commented Jul 4, 2023

View reviewed changes

x-pack/plugins/alerting/server/task_runner/execution_handler.ts Outdated Show resolved Hide resolved

XavierM and others added 7 commits September 13, 2023 20:43

Merge branch 'main' of github.com:elastic/kibana into 158183-executio…

39e7854

…n-handler-refactor

Merge branch 'main' of github.com:elastic/kibana into 158183-executio…

8770756

…n-handler-refactor

almost there + full plumbing for useAlertDataForTemplate

e09c812

clean up + move aad switch to a generic position

92a3551

space between switch and form

045576e

fix jest tests

ff98eb1

update snapshot

c6a018c

jcger commented Sep 20, 2023

View reviewed changes

jcger and others added 17 commits September 21, 2023 12:32

add feature flags and autocomplete compont to triggers_actions_ui

eac5015

fix test

597b06d

fix tests

a3ac65c

fix tests

4f1a43e

fix tests

abdd1aa

Merge branch 'main' into 158183-execution-handler-refactor

c61caa6

rollback ff init and catch error

2d67457

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

78e00dd

…fix'

catch switch ff error

6905044

Merge branch '158183-execution-handler-refactor' of github.com:jcger/…

3d33741

…kibana into 158183-execution-handler-refactor

fix test

25cd6e3

Merge branch 'main' of github.com:jcger/kibana into 158183-execution-…

a8a891e

…handler-refactor

Merge branch 'main' into 158183-execution-handler-refactor

c214fa5

rollback state

e6216f3

Merge branch '158183-execution-handler-refactor' of github.com:jcger/…

c277450

…kibana into 158183-execution-handler-refactor

fix test

24d3ccb

Merge branch 'main' of github.com:jcger/kibana into 158183-execution-…

ea05545

…handler-refactor

Zacqary self-assigned this Oct 25, 2023

Zacqary mentioned this pull request Oct 30, 2023

[RAM] Add toggle for AAD fields in alert templating #170162

Merged

1 task

Zacqary closed this Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM] Use AAD When Running Action #161213

[RAM] Use AAD When Running Action #161213

jcger commented Jul 4, 2023 •

edited

jcger Sep 20, 2023

kibana-ci commented Sep 26, 2023 •

edited

API count

ESLint disabled line counts

Total ESLint disabled count

mdefazio commented Oct 17, 2023 •

edited

mdefazio commented Oct 17, 2023

Zacqary commented Oct 25, 2023

Zacqary commented Oct 30, 2023

[RAM] Use AAD When Running Action #161213

[RAM] Use AAD When Running Action #161213

Conversation

jcger commented Jul 4, 2023 • edited

Summary

jcger Sep 20, 2023

Choose a reason for hiding this comment

kibana-ci commented Sep 26, 2023 • edited

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

mdefazio commented Oct 17, 2023 • edited

mdefazio commented Oct 17, 2023

Zacqary commented Oct 25, 2023

Zacqary commented Oct 30, 2023

jcger commented Jul 4, 2023 •

edited

kibana-ci commented Sep 26, 2023 •

edited

mdefazio commented Oct 17, 2023 •

edited