Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Add toggle for AAD fields in alert templating #170162

Merged
merged 39 commits into from Nov 14, 2023

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 30, 2023

Summary

Reopen of #161213

Closes #160838

Feature can be activated via feature flag:
xpack.trigger_actions_ui.enableExperimental: ['isMustacheAutocompleteOn', 'showMustacheAutocompleteSwitch']
Screenshot 2023-10-30 at 5 52 39 PM
Screenshot 2023-10-30 at 5 52 22 PM

Checklist

jcger and others added 28 commits July 4, 2023 18:48
…kibana into 158183-execution-handler-refactor
…kibana into 158183-execution-handler-refactor
…ion-handler-refactor

# Conflicts:
#	x-pack/plugins/alerting/server/alert/alert.ts
#	x-pack/plugins/stack_connectors/tsconfig.json
@Zacqary Zacqary added release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 30, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 30, 2023

Reverted making ruleTypeId a required prop to avoid triggering Security Solution codeowner

Security Solution will need to pass ruleTypeId into the action form in order to take advantage of this enhancement. Will open an issue.

@Zacqary Zacqary changed the title [RAM] Use AAD When Running Action [RAM] Add toggle for AAD fields in alert templating Oct 30, 2023
@Zacqary Zacqary marked this pull request as ready for review October 31, 2023 18:02
@Zacqary Zacqary requested a review from a team as a code owner October 31, 2023 18:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@Zacqary Zacqary enabled auto-merge (squash) October 31, 2023 18:07
auto-merge was automatically disabled November 7, 2023 05:06

Merge queue setting changed

Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary enabled auto-merge (squash) November 14, 2023 15:13
…ndler-refactor

# Conflicts:
#	x-pack/plugins/alerting/server/task_runner/execution_handler.ts
#	x-pack/plugins/stack_connectors/common/experimental_features.ts
#	x-pack/plugins/triggers_actions_ui/tsconfig.json
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackConnectors 272 236 -36
triggersActionsUi 616 621 +5
total -31

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 778 779 +1
triggersActionsUi 555 557 +2
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 556.4KB 537.4KB -18.9KB
triggersActionsUi 1.4MB 1.4MB +2.1KB
total -16.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 39.5KB 39.3KB -245.0B
triggersActionsUi 97.3KB 103.9KB +6.6KB
total +6.4KB
Unknown metric groups

API count

id before after diff
alerting 809 810 +1
triggersActionsUi 581 583 +2
total +3

ESLint disabled line counts

id before after diff
stackConnectors 104 103 -1
triggersActionsUi 126 127 +1
total -0

Total ESLint disabled count

id before after diff
stackConnectors 109 108 -1
triggersActionsUi 132 133 +1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 603a045 into elastic:main Nov 14, 2023
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 14, 2023
jillguyonnet pushed a commit to jillguyonnet/kibana that referenced this pull request Nov 16, 2023
## Summary

Reopen of elastic#161213

Closes elastic#160838

Feature can be activated via feature flag:
`xpack.trigger_actions_ui.enableExperimental:
['isMustacheAutocompleteOn', 'showMustacheAutocompleteSwitch']`
<img width="605" alt="Screenshot 2023-10-30 at 5 52 39 PM"
src="https://github.com/elastic/kibana/assets/1445834/da24b419-3b08-4014-be2f-99692773755f">
<img width="583" alt="Screenshot 2023-10-30 at 5 52 22 PM"
src="https://github.com/elastic/kibana/assets/1445834/fc5b8a1e-8202-4491-b4fb-694b70809f4d">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAM] Update the platform to allow actions to query directly the alert as data
7 participants