New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Implement private location run once #162582
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
abc4938
to
08a8cf8
Compare
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/uptime (Team:uptime) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResponseOps changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Observations
Results from Pre-flight test runs (triggered via Run test on monitor Add/Edit page) are getting listed on the monitor details page. Also happens on main
so it's not a regression in this PR.
commit 7ea6ea2 Merge: 821f342 fdc3863 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 31 13:29:41 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit 821f342 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 31 13:27:03 2023 -0400 Break down app features into specific endpoint functional areas commit fdc3863 Merge: d9000a6 3efb838 Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Mon Jul 31 13:19:50 2023 -0400 Merge branch 'main' into task/olm-7053-serverless-pli-authz commit 3efb838 Author: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Date: Mon Jul 31 13:18:36 2023 -0400 [Security Solution] Skip file operations tests until ES permissions is fixed (elastic#162787) ## Summary Skip the broken File Operations tests until a permissions issue in ES is fixed: elastic#162760 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 92db0d3 Author: Youhei Sakurai <youhei.sakurai@elastic.co> Date: Tue Aug 1 02:14:21 2023 +0900 Allow variable names with underscores (elastic#162208) Closes elastic#162205 ## Summary With this PR, users will be able to define variables with names containing underscores (`_`) like the below picture. ![image](https://github.com/elastic/kibana/assets/721858/d6aa0b4c-0c12-4fe7-ab3f-da0aa5cc8862) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit db42331 Author: Alison Goryachev <alison.goryachev@elastic.co> Date: Mon Jul 31 13:05:59 2023 -0400 [ILM] Unskip API integration test (elastic#162525) commit 235c6ec Author: Justin Kambic <jk@elastic.co> Date: Mon Jul 31 13:02:24 2023 -0400 [Synthetics] Fix TS error for TS upgrade (elastic#162822) ## Summary Fixes the TS error encountered in elastic#162738 in the synthetics plugin. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) commit a1bc199 Author: Tiago Costa <tiago.costa@elastic.co> Date: Mon Jul 31 17:10:42 2023 +0100 skip flaky suites (elastic#162813) commit 2d17d75 Author: ruhshan <ruhshan.ahmed@gmail.com> Date: Mon Jul 31 22:02:20 2023 +0600 Update role mappings empty UI for consistency (elastic#162357) ## Summary Fixes elastic#161137 Update style of empty role mappings prompt to meet consistency. ![image](https://github.com/elastic/kibana/assets/5312918/f419de0e-177a-4fac-aa36-1c6ec5f0d6c6) Update icon of create api key button of empty api key prompt. ![image](https://github.com/elastic/kibana/assets/5312918/9b69e91a-9267-42d7-85f0-aca1507879af) ### Checklist Delete any items that are not applicable to this PR. - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> commit 7b2a00a Author: Sander Philipse <94373878+sphilipse@users.noreply.github.com> Date: Mon Jul 31 17:57:55 2023 +0200 [Serverless] Update left nav, disable ML alerts (elastic#162728) ## Summary This updates the left nav of Serverless Search to match the latest designs, and disables ML alerting rules. --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 96de148 Author: Walter Rafelsberger <walter.rafelsberger@elastic.co> Date: Mon Jul 31 17:39:25 2023 +0200 [ML] `@kbn/ml-response-stream`: Fix race condition related to throttling. (elastic#162803) Fixes a race condition in the case where a response stream finishes and sets `isRunning` to `false`, but `useThrottle` didn't trigger it's last update yet within the refresh rate. In the case of log rate analysis, `isRunning` could be set to `false` too early and the UI wouldn't consider later throttled updates (for example, setting `loaded=1` which would result in inconsistent UI state). The fix in this case is to return the unthrottled raw data instead of the throttled one as soon as the stream finished. commit f0050db Author: Rickyanto Ang <rickyangwyn@gmail.com> Date: Mon Jul 31 08:38:59 2023 -0700 [Cloud Security][Onboarding]GCP Onboarding - Manual (IMPROVEMENTS) (elastic#162434) ## Summary Addressing PR Comments + Improvements from my previous PR (elastic#161913) in this PR commit 9900c08 Author: Adam Demjen <demjened@gmail.com> Date: Mon Jul 31 11:26:00 2023 -0400 [Enterprise Search] Switch ML inference config to use the multi field selector (elastic#162657) ## Summary Switching over to the multi field selector component for non-ELSER pipelines. We're also cleaning up obsolete code: - Remove `sourceField`, `destinationField`, `inferenceConfig` references - Remove generation of field mappings and full pipeline definition from `sourceField` and `destinationField` ![field_config_non_elser](https://github.com/elastic/kibana/assets/14224983/4f5910dc-1347-4293-8dbc-113d3c70b799) Use cases tested manually: - Create ELSER pipeline - Create non-ELSER pipeline - Create non-ELSER pipeline with custom target field name - Attach ELSER pipeline - Attach non-ELSER pipeline ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - ~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - will do in a separate PR - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit 0728003 Author: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com> Date: Mon Jul 31 10:24:01 2023 -0500 [ML] Add new Data comparison view (elastic#161365) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit b0fbe93 Author: Philippe Oberti <philippe.oberti@elastic.co> Date: Mon Jul 31 17:06:17 2023 +0200 [Security Solution] - expandable flyout - code owners (elastic#162792) commit 5369eb3 Author: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co> Date: Mon Jul 31 17:01:23 2023 +0200 [APM] Fix throwing appropriate error when user is missing necessary permission (elastic#162466) Closes elastic#126078 Currently the 2 places where the user can create Agent Key already handles the situation by not displaying the option to user with limited permissions. 1. Observability - Settings 2. Stack Management -> API Keys [Public API](https://www.elastic.co/guide/en/kibana/current/agent-key-api.html) is still available to create Agent Keys. With this change the below would happen ### Request ``` curl -X POST "http://localhost:5601/{basePath}/api/apm/agent_keys" \ -u editor:changeme \ -H "Content-Type: application/json" \ -H "Elastic-Api-Version: 2023-10-31" \ -H "kbn-xsrf: true" \ -d '{ "name": "apm-key", "privileges": ["event:write", "config_agent:read"] }' ``` ### Response ``` { "statusCode": 403, "error": "Forbidden", "message": "editor is missing the following requested privilege(s): config_agent:read, event:write and following cluster privileges - manage_api_key, manage_own_api_key privilege(s). You might try with the superuser, or add the missing APM application privileges to the role of the authenticated user, eg.:\n PUT /_security/role/my_role\n {\n ...\n \"applications\": [{\n \"application\": \"apm\",\n \"privileges\": [\"config_agent:read\",\"event:write\"],\n \"resources\": [*]\n }],\n ...\n }", "attributes": { "data": { "missingPrivileges": [ "config_agent:read", "event:write" ], "missingClusterPrivileges": [ "manage_api_key", "manage_own_api_key" ] }, "_inspect": [ ] } } ``` commit 832aec0 Author: Clint Andrew Hall <clint.hall@elastic.co> Date: Mon Jul 31 16:51:28 2023 +0200 [regression] Fix Storybooks after elastic#161914 (elastic#162757) ## Summary As titled. This PR corrects a pair of mistakes I made before committing elastic#161914 that @dgieselaar identified shortly thereafter. - I had tested Storybook extensively, but after I rebased, I changed the render context, and I forgot to update the `decorator` in Storybook. This meant Emotion styles worked, but the EUI styles were missing. - In addition, when I rebased, I missed the addition of the utils cache that had been added by EUI. - Interestingly, elastic#162365 missed adding the cache `meta` tag to the template. Emotion simply added the styles to the `head`, but it's best to reproduce what we see in Kibana. So I've corrected that, as well. - While creating the PR, I went ahead and addressed [feedback](elastic#161914 (comment)) from @cee-chen on the original PR./ Sorry if anyone was confused by the sudden drop in styles in their Storybooks. Should be resolved now. Thanks! --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit 90a8823 Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Mon Jul 31 10:49:40 2023 -0400 [Security Solution][Serverless] Remove esArchive data load from Cypress test runner (elastic#162797) ## Summary - Remove esArchive load from Cypress runner (data should be loaded by individual tests and not globally across all tests) commit 46a073f Author: Ignacio Rivas <rivasign@gmail.com> Date: Mon Jul 31 17:41:40 2023 +0300 Revert "[Remote Clusters] Clean up null properties depending on conection mode" (elastic#162780) Reverts elastic#162405 commit bf5c270 Author: Saikat Sarkar <132922331+saikatsarkar056@users.noreply.github.com> Date: Mon Jul 31 08:26:34 2023 -0600 [ELSER] Remove missing type hints related to the inference config (elastic#162602) This pr is related to issue: elastic/enterprise-search-team#4432 This change involves removing hints related to the inference_config attribute --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> commit fa01462 Author: Shahzad <shahzad31comp@gmail.com> Date: Mon Jul 31 16:22:49 2023 +0200 [Synthetics] Clean up common dir (elastic#162692) commit 0367514 Author: Carlos Crespo <crespocarlos@users.noreply.github.com> Date: Mon Jul 31 16:19:11 2023 +0200 [Infra UI] Chart load optimization (elastic#162328) Closes elastic#161445 ## Summary This PR enhances the usage of the intersection observer to control the loading behavior of charts, improving the performance, especially noticeable during scrolling. Before https://github.com/elastic/kibana/assets/2767137/dfb1d7db-4ddb-41c3-b8ae-3b5bdf3fe36e After https://github.com/elastic/kibana/assets/2767137/f348b0b9-4e6f-4163-9eb4-99daea91bbef Besides, the intersection observer threshold has been set to 0, allowing charts to start loading as soon as they begin to enter the viewport. ### How to test - Start a local Kibana instance - Navigate to `Infrastructure > Hosts` - Scroll down and confirm that it's not laggy (same for the flyout) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 0cc81d7 Author: Sandra G <neptunian@users.noreply.github.com> Date: Mon Jul 31 10:09:30 2023 -0400 [Logs Shared] remove observability dependency (elastic#162733) After the obs ai assistant [moved to its own plugin](elastic#162243) outside the observability plugin, logs_shared shouldn't need to depend on observability Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit 770c4a2 Author: Julia Rechkunova <julia.rechkunova@elastic.co> Date: Mon Jul 31 15:54:47 2023 +0200 [Discover] Fix grid styles to enable better wrapping (elastic#162325) Closes elastic#162304 ## Summary This PR fixes the issue with cell content wrapping. Before it was just cut off. Now it falls to the next line. Please check that there is no regression for elastic#139449 Before: <img width="600" alt="Screenshot 2023-07-20 at 15 03 16" src="https://github.com/elastic/kibana/assets/1415710/c91e0922-33a2-4008-a797-8f04f1b0b758"> After: <img width="600" alt="Screenshot 2023-07-20 at 15 02 34" src="https://github.com/elastic/kibana/assets/1415710/754ee9f3-b33c-4c31-b27d-801e3fe89c78"> ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) commit 4eac242 Author: Shahzad <shahzad31comp@gmail.com> Date: Mon Jul 31 15:53:40 2023 +0200 [Synthetics] Implement private location run once (elastic#162582) ## Summary Implement private location run once mode , user will be able to do run once or test now for private locations as well. This implemented a task manager which will clean up temporarily created package policies created for the purpose of run once and test now mode. <img width="1718" alt="image" src="https://github.com/elastic/kibana/assets/3505601/e5ac3a52-516f-48eb-953f-fa573d825a57"> commit 2279dce Author: Aleh Zasypkin <aleh.zasypkin@elastic.co> Date: Mon Jul 31 15:48:36 2023 +0200 Re-enable security related tests related to the concurrent access token refresh. (elastic#162693) ## Summary Since elastic/elasticsearch#98011 is merged, we can re-enable our tests as soon as ES snapshot is promoted. I run a few of these tests locally against Elasticsearch built from source and they were passing. __Fixes: https://github.com/elastic/kibana/issues/162581__ __Fixes: https://github.com/elastic/kibana/issues/162583__ __Fixes: https://github.com/elastic/kibana/issues/162584__ __Fixes: https://github.com/elastic/kibana/issues/162586__ commit 02a43a1 Author: Patryk Kopyciński <contact@patrykkopycinski.com> Date: Mon Jul 31 15:42:45 2023 +0200 Adjust cypress jobs config (elastic#162729) ## Summary Adjust cypress buildkite job configs --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> commit d9000a6 Merge: 038be31 6b44fff Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Mon Jul 31 08:33:14 2023 -0400 Merge branch 'main' into task/olm-7053-serverless-pli-authz commit 038be31 Merge: e670547 c894aa7 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 29 10:28:30 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit e670547 Merge: fdfaa8a 97176a5 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 29 10:28:07 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz commit fdfaa8a Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 29 10:27:14 2023 -0400 add additional directory to code owners commit c894aa7 Merge: db49ffe 5864674 Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Fri Jul 28 16:51:05 2023 -0400 Merge branch 'main' into task/olm-7053-serverless-pli-authz commit db49ffe Merge: be52694 f0ebb70 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 12:06:48 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz commit be52694 Merge: aea9e57 ab45d4c Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 12:06:20 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit aea9e57 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 12:04:21 2023 -0400 set default login user to `soc_manager` commit 750792c Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 12:00:42 2023 -0400 Add response action access to feature access checks for enpoint pli commit d55754e Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 11:49:36 2023 -0400 Added tests to Essentials to validate no access to response actions commit 3ff3741 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 11:46:42 2023 -0400 Added tests to validate no access to response actions from Complete PLI commit 1f99981 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 11:45:36 2023 -0400 Tasks for response actions commit 1e085ca Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 11:45:07 2023 -0400 `login()` task now return the username/password of the logged in user commit 1df3a37 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 28 11:44:01 2023 -0400 Fix issue with headers not being extendable when attempting to use `request()` with Form data commit ab45d4c Merge: eb7d467 8df8920 Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Fri Jul 28 08:32:04 2023 -0400 Merge branch 'main' into task/olm-7053-serverless-pli-authz commit eb7d467 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 15:54:35 2023 -0400 fix export commit 4e48410 Merge: bdbb57f 5cab014 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 15:28:10 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit bdbb57f Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 15:27:35 2023 -0400 Added `ensurePolicyListPageAuthzAccess()` commit fe50df2 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 15:17:46 2023 -0400 add `visitEndpointArtifactPage()` screen helper for artifacts commit c7108b3 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 15:15:02 2023 -0400 added `ensureEndpointListPageAuthzAccess()` and refactor tests commit 5cab014 Author: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Thu Jul 27 19:00:52 2023 +0000 [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' commit bd27fa5 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 14:58:43 2023 -0400 Renamed `ensureProperArtifactPageAuthzAccess` to `ensureArtifactPageAuthzAccess` commit cc81faa Merge: 1a54923 c968f1f Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 14:53:59 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit 1a54923 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 14:53:44 2023 -0400 use `ensureProperArtifactPageAuthzAccess()` for validating access to artifacts commit c968f1f Merge: 137eb63 614044b Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Thu Jul 27 14:40:26 2023 -0400 Merge branch 'main' into task/olm-7053-serverless-pli-authz commit b5b2cd9 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 12:01:32 2023 -0400 Fix: correctly determine if url is localhost commit 137eb63 Merge: a247063 c82b679 Author: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Date: Thu Jul 27 11:50:08 2023 -0400 Merge branch 'main' into task/olm-7053-serverless-pli-authz commit a247063 Merge: d1ef247 c9c6154 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 08:32:45 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz commit d1ef247 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 08:32:24 2023 -0400 Adjust test in Essentials to show no app feature access to host isolation exceptions commit c72075c Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 27 08:28:58 2023 -0400 fix responder screen helper commit a4dd6f4 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 18:21:08 2023 -0400 updated roles yaml file with latest commit a2709fc Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 18:04:04 2023 -0400 Fix call to `getByTestSubj` and adjust log() commit b8aca30 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 17:04:21 2023 -0400 updated code owners for serverless tests commit 375fc79 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 16:25:21 2023 -0400 fix tests for endpoint_policy_manager commit b6efd4b Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 16:03:49 2023 -0400 Fix endpoint list screen utilities commit f8819cb Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 16:02:48 2023 -0400 Fix code for `getByTestSubj()` so that it throws error if chained off another subject commit 54e7184 Merge: dfb1736 7c16dd9 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 11:18:35 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz # Conflicts: # x-pack/plugins/security_solution_serverless/server/plugin.ts commit dfb1736 Merge: 80be432 bf98473 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 11:16:49 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit 80be432 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 11:16:22 2023 -0400 Fixes to roles tests commit c734aef Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 10:47:44 2023 -0400 replace use of `findByTestSubj` with `getByTestSubj` commit bf98473 Author: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Wed Jul 26 14:45:53 2023 +0000 [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' commit a102bb8 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 10:38:53 2023 -0400 add validation code to YAML roles parser commit b5b86a1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 10:29:58 2023 -0400 correct role name commit 7e8b435 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 10:02:26 2023 -0400 Copied cypress.d.ts values from endpoint management cypress suite to serverless commit b7a268f Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:59:13 2023 -0400 fix login user in role test files commit abd8922 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:56:39 2023 -0400 updated security roles YAML commit 5c85a26 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:54:23 2023 -0400 adjust tests for Essentials - host isolation exceptions not accessible commit dc9ee3d Merge: d1a8944 ad542d0 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:50:26 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz # Conflicts: # x-pack/plugins/security_solution/tsconfig.json # x-pack/plugins/security_solution_serverless/public/navigation/index.ts # x-pack/plugins/security_solution_serverless/public/plugin.ts commit d1a8944 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:45:16 2023 -0400 back out change to login() commit cfbc429 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:44:42 2023 -0400 move Host Isolation Exceptions to Endpoint Complete commit ab31847 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:35:53 2023 -0400 make `soc_manager` the default login user commit ac846d7 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 26 08:34:22 2023 -0400 Adjust implementation of `getTableRow()` endpoint list screen helper commit d9935ee Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 18:22:35 2023 -0400 Updated tests for new YAML roles commit eddda59 Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 17:42:31 2023 -0400 updated project controller security roles YAML file commit 735d147 Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 16:40:06 2023 -0400 Fix ELASTICSEARCH_URL not being defined commit ec2cead Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 15:19:15 2023 -0400 refactor: move `lib` stuff to endpoint screens folder commit 000c9ed Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 15:12:20 2023 -0400 Permission tests for Security Complete with Endpoint Complete commit 941b3c1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 12:19:00 2023 -0400 add essentials tests to the Complete test suite commit 509ab0b Merge: 031133d 492cfdf Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 12:11:06 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz # Conflicts: # x-pack/plugins/security_solution/tsconfig.json # x-pack/plugins/security_solution_serverless/server/plugin.ts commit 031133d Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 12:08:43 2023 -0400 Correct test commit 63c40ff Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 12:08:23 2023 -0400 Enhance `login()` task commit 3a4dbb1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 12:07:29 2023 -0400 Change non-serverless config for cypress to use `system_indices_superuser` for ES commit e0d00ac Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 12:05:44 2023 -0400 Additional logging in role loader and fixing of YAML commit ab29f37 Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 11:36:21 2023 -0400 fix bug in `login()` commit 63af698 Author: Paul Tavares <paul.tavares@elastic.co> Date: Tue Jul 25 09:59:24 2023 -0400 tests for SOC Manager, Platform Engineer and Endpoint Operations Manager commit d143f27 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 18:39:49 2023 -0400 tests for Rule Author role commit 1d8c561 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 18:30:53 2023 -0400 Tests for roles in Essentials with Endpoint role + common screen defintions commit 63d8987 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 16:11:04 2023 -0400 BACKOUT changes to the SIEM cypress setup commit 78bd106 Merge: b622895 04e8d53 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 16:08:28 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit b622895 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 15:57:04 2023 -0400 include some temp test in files to avoid CI failure commit e640218 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 15:43:41 2023 -0400 back out changes to fleet cypress setup commit 04e8d53 Author: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Mon Jul 24 18:04:55 2023 +0000 [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' commit e03520d Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 13:40:23 2023 -0400 Tests for Security Complete with Endpoint Complete commit 25efef1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 12:41:15 2023 -0400 Tests for Security Essentials with Endpoint Essentials addon commit 4f3881e Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 11:47:02 2023 -0400 Correct comment commit 04e82f1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 11:45:42 2023 -0400 correct directory name commit 96c45ae Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 11:44:33 2023 -0400 Fix override of product types commit 627bb77 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 11:20:22 2023 -0400 Move loging of config to be done prior to start of stack commit 75ff883 Author: Paul Tavares <paul.tavares@elastic.co> Date: Mon Jul 24 11:19:53 2023 -0400 add log to serverless plugin to log product tiers on Plugin `setup()` commit 957fca9 Merge: 5b09c87 94df082 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 16:05:57 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz commit 5b09c87 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 16:05:37 2023 -0400 adjust cases notes test commit be2f62a Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 14:48:05 2023 -0400 temporarly silence TS error on test files commit bc3307a Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 14:44:30 2023 -0400 fix env. var name commit d228eb9 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 13:54:58 2023 -0400 Create Env. vars `ELASTICSEARCH_URL_WITH_AUTH` and `KIBANA_URL_WITH_AUTH` commit d8d283a Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 11:08:14 2023 -0400 another adjustment to the use of correct env. variables commit ca1df24 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 10:54:26 2023 -0400 Update most instances that use `ELASTICSEARCH_USERNANE/PASSWORD` for login to use `KIBANA_*` equivalent commit 39af608 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 10:53:28 2023 -0400 Addes test files to check endpoint roles commit b90d221 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sun Jul 23 10:21:00 2023 -0400 delete unused methods from `login.ts` commit e63f38d Merge: 463428c ef5f741 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 18:31:21 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit 463428c Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 18:30:53 2023 -0400 Add KIBANA_USERNAME/PASSWORD env. vars and adjust code to use it where appropriate commit ef5f741 Author: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Sat Jul 22 17:05:48 2023 +0000 [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' commit 0193312 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 12:59:56 2023 -0400 Fix Env. variables and ensure URLs are built correctly when needed with creds commit f57bbe1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 12:30:57 2023 -0400 fix jest test commit 9a3eb9b Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 11:32:42 2023 -0400 logging of loaded app features config commit 76ef4e3 Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 11:32:15 2023 -0400 Adds types to SuiteConfigOverrides for `env.ftrConfig` commit 66c3cfd Merge: cfcb33c 2d7473c Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 10:18:22 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz commit cfcb33c Author: Paul Tavares <paul.tavares@elastic.co> Date: Sat Jul 22 10:17:46 2023 -0400 Fix (cypress parallel): string out trailing `/` from urls defined in Cy ENV commit 06ab295 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 20:50:24 2023 -0400 fix adding of product types to serverArgs commit 3262977 Merge: 0c369b2 737a1c9 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 19:32:01 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit 0c369b2 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 19:31:50 2023 -0400 Add support for defining the `productTypes` in cypress tests commit 4b663d3 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 17:51:24 2023 -0400 tests for Complete PLI commit 6455e2f Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 17:49:15 2023 -0400 tests for essentials commit 5f8def9 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 17:48:54 2023 -0400 Add `lib` folder and library for retrieving endpoint list of pages commit 635b67b Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 17:47:46 2023 -0400 ignore 409 messages when creating roles/users commit 1a788d0 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 12:32:44 2023 -0400 Change Cypress parallel runner so that it provides ENV variables for current run servers commit 8be7f03 Author: Paul Tavares <paul.tavares@elastic.co> Date: Fri Jul 21 12:31:20 2023 -0400 Add `waitForKibana()` to scripts common ++ use it in `createRuntimeServices()` commit 737a1c9 Author: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Thu Jul 20 23:37:11 2023 +0000 [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' commit 0096c81 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 19:30:59 2023 -0400 test file setup + tasks for cypress to load users/roles commit 138c117 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 19:30:11 2023 -0400 Fix bugs in kibana roles lib commit 2beaa78 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 19:29:43 2023 -0400 Initialize ToolingLog with write to stdout commit 857912f Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 16:32:26 2023 -0400 Add package.json script for `cypress` commit 5c208cd Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 16:23:29 2023 -0400 moved FTR tests under `ftr` directory commit 6fddca3 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 16:08:15 2023 -0400 Role and user loader for security commit d8cbec1 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 15:33:10 2023 -0400 move kibana roles parser to be under `shared/lib` commit 83e9a4c Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 12:23:57 2023 -0400 add missing sub feature id to endpoint complete commit f22d350 Merge: 7465812 93f715b Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 11:43:53 2023 -0400 Merge remote-tracking branch 'upstream/main' into task/olm-7053-serverless-pli-authz commit 7465812 Merge: 7b5022a ac4c638 Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 11:43:46 2023 -0400 Merge remote-tracking branch 'origin/task/olm-7053-serverless-pli-authz' into task/olm-7053-serverless-pli-authz commit 7b5022a Author: Paul Tavares <paul.tavares@elastic.co> Date: Thu Jul 20 09:38:56 2023 -0400 adjust error message commit ac4c638 Author: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Wed Jul 19 23:01:18 2023 +0000 [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --fix' commit 675710f Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 19 18:55:22 2023 -0400 Service to get list of Kibana Role definitions for serverless commit 73e3978 Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 19 16:21:33 2023 -0400 Define endpoint set of kibana privileges for both Essential and Complete commit 20e44dd Author: Paul Tavares <paul.tavares@elastic.co> Date: Wed Jul 19 14:23:20 2023 -0400 introduce `xpack.securitySolutionServerless.developer` options into the serverless plugin config
## Summary Implement private location run once mode , user will be able to do run once or test now for private locations as well. This implemented a task manager which will clean up temporarily created package policies created for the purpose of run once and test now mode. <img width="1718" alt="image" src="https://github.com/elastic/kibana/assets/3505601/e5ac3a52-516f-48eb-953f-fa573d825a57">
Summary
Implement private location run once mode , user will be able to do run once or test now for private locations as well.
This implemented a task manager which will clean up temporarily created package policies created for the purpose of run once and test now mode.