Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventLog] change to use Data stream lifecycle instead of ILM #163210

Merged
merged 3 commits into from Aug 8, 2023

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Aug 4, 2023

resolves #162886

The default continues to be 90 days for data detetention of event log documents, and the rollover is now controlled by DLM, as described in Data stream lifecycle.

Release note

Fixes the event log data stream to use Data stream lifecycle instead of Index Lifecycle Management. If you had previously customized the Kibana event log ILM policy, you should now update the lifecycle of the event log data stream itself.

Checklist

Delete any items that are not applicable to this PR.

@pmuellr pmuellr added release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog labels Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Documentation preview:

The default continues to be 90 days for data detetention of event
log documents, and the rollover is now controlled by DLM, as
described in [Data stream lifecycle][].

[Data stream lifecycle]: https://www.elastic.co/guide/en/elasticsearch/reference/8.9/data-stream-lifecycle.html

Fixes the event log data stream to use Data stream lifecycle instead of
Index Lifecycle Management.  If you had previously customized the
Kibana event log ILM policy, you should now update the lifecycle of
the event log data stream itself.
@pmuellr pmuellr added the docs label Aug 7, 2023
@pmuellr pmuellr marked this pull request as ready for review August 7, 2023 12:48
@pmuellr pmuellr requested a review from a team as a code owner August 7, 2023 12:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@pmuellr
Copy link
Member Author

pmuellr commented Aug 7, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

  • Buildkite Build
  • Commit: 76f611a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-163210-76f611aab08b

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventLog 116 111 -5
Unknown metric groups

API count

id before after diff
eventLog 116 111 -5

ESLint disabled line counts

id before after diff
eventLog 4 3 -1

Total ESLint disabled count

id before after diff
eventLog 4 3 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmuellr pmuellr merged commit 7e234b1 into elastic:main Aug 8, 2023
6 checks passed
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 8, 2023
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
…c#163210)

resolves elastic#162886

The default continues to be 90 days for data detetention of event log
documents, and the rollover is now controlled by DLM, as described in
[Data stream lifecycle][].

[Data stream lifecycle]:
https://www.elastic.co/guide/en/elasticsearch/reference/8.9/data-stream-lifecycle.html

## Release note

Fixes the event log data stream to use Data stream lifecycle instead of
Index Lifecycle Management. If you had previously customized the Kibana
event log ILM policy, you should now update the lifecycle of the event
log data stream itself.
pmuellr added a commit to pmuellr/kibana that referenced this pull request Aug 23, 2023
…elastic#163210)"

This reverts commit 7e234b1.a

The commit came from PR elastic#163210

See elastic#164581 for the issue the original
PR caused.
pmuellr added a commit that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-serverless-image ci:serverless-test-all docs Feature:EventLog release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
Development

Successfully merging this pull request may close these issues.

[EventLog] change to use DLM instead of ILM
5 participants