Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[EventLog] change to use Data stream lifecycle instead of ILM" #164614

Merged
merged 1 commit into from Aug 24, 2023

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Aug 23, 2023

Resolves #164581.

This reverts commit 7e234b1

The commit came from PR #163210

See #164581 for the issue the original PR caused.

…elastic#163210)"

This reverts commit 7e234b1.a

The commit came from PR elastic#163210

See elastic#164581 for the issue the original
PR caused.
@pmuellr pmuellr added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog v8.10.0 labels Aug 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@github-actions
Copy link

Documentation preview:

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmuellr pmuellr added the release_note:skip Skip the PR/issue when compiling release notes label Aug 23, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventLog 111 116 +5
Unknown metric groups

API count

id before after diff
eventLog 111 116 +5

ESLint disabled line counts

id before after diff
eventLog 3 4 +1

Total ESLint disabled count

id before after diff
eventLog 3 4 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr
Copy link
Member Author

pmuellr commented Aug 23, 2023

Tested this locally and seems like it works; note you MUST use a DRA build and not a snapshot build, as the snapshot builds somehow enable the dlm feature flag in ES, which enables DLM, but is not enabled by default in 8.10 .0 release.

ensure old behavior can be reproduced, doesn't happen in dev / ci:

  • start es via yarn es archive ~/Downloads/elasticsearch-8.10.0-darwin-aarch64.tar.gz --license trial
  • check Kibana out at branch 8.10 (without this code)
  • start kibana via yarn start
  • observe the existing error eventLog initialization operation failed and will be retried: createIndexTemplateIfNotExists in the logs

ensure new code fixes this

  • start es the exact same way
  • check out this branch of Kibana
  • start kibana via yarn start
  • observe the event log initializes correctly

I created some rules, checked that the event log is being populated, UX like rule alerts / logs now working again.

@pmuellr pmuellr merged commit 697577a into elastic:8.10 Aug 24, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:EventLog release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants