Run Prettier for JS files #16338
Closed
Run Prettier for JS files #16338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
jbudz
reviewed
Jan 29, 2018
| @@ -30,6 +30,7 @@ module.exports = function (grunt) { | |||
| 'rejectRejFiles', | |||
|
|
|||
| 'run:eslint', | |||
| 'run:prettier', | |||
There was a problem hiding this comment.
thoughts on https://github.com/prettier/eslint-plugin-prettier?
There was a problem hiding this comment.
👍 Yeah, that was just to keep the PR clean as we squash commit this stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15106 seems to have stalled, so I thought I'd try to get the ball going.
This doesn't run Prettier as a pre-commit hook as it takes too long time to run imo:
However, in #16339 I show how we can enable this for a specific path, including running Prettier together with ESLint (which means it will hook into the existing pre-commit setup)