Prettier + ESLint setup #16514
Merged
Prettier + ESLint setup #16514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
kimjoar
force-pushed
the
platform/prettier-using-eslint
branch
from
7f923db
to
8a00dd5
Compare
kimjoar
force-pushed
the
platform/prettier-using-eslint
branch
from
8a00dd5
to
a693bc8
Compare
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
kimjoar
added a commit
to kimjoar/kibana
that referenced
this pull request
Feb 5, 2018
* Move .eslintrc (yaml) to .eslintrc.js (js) * Add Prettier setup to ESLint * Run Prettier on @kbn/build * Update style guide with Prettier
This was referenced Feb 5, 2018
Closed
kimjoar
added a commit
that referenced
this pull request
Feb 5, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new take on #16338 and #16339, this time only based on how we run ESLint.
This can be reviewed commit by commit. I also added a note in the styleguide.
What do you think, @spalger?