Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with disabled lab mode #16351

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Fix issue with disabled lab mode #16351

merged 2 commits into from
Jan 30, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jan 29, 2018

This PR fixes an issue where you cannot load saved searches, embed them into dashboards, load timelion sheets, etc. while visualize:enableLabs is turned off in advanced settings.

Fix #16349

@timroes timroes added bug Fixes for quality problems that affect the customer experience release_note:fix v7.0.0 v6.2.0 v6.3.0 labels Jan 29, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Jan 29, 2018
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 232b267 into elastic:master Jan 30, 2018
@timroes timroes deleted the fix-saved-object-finder branch January 30, 2018 08:56
@timroes timroes mentioned this pull request Jan 30, 2018
Closed
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
@timroes
Fix issue with disabled lab mode (elastic#16351)
98c655a 
* Fix saved object finder issue

* Add functional test
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
@timroes
Fix issue with disabled lab mode (elastic#16351)
17e6810 
* Fix saved object finder issue

* Add functional test
This was referenced Jan 30, 2018
Closed
Merged
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
@timroes
Fix issue with disabled lab mode (elastic#16351)
58a11b7 
* Fix saved object finder issue

* Add functional test
timroes added a commit to timroes/kibana that referenced this pull request Jan 30, 2018
@timroes
Fix issue with disabled lab mode (elastic#16351)
4a22f94 
* Fix saved object finder issue

* Add functional test
@timroes timroes mentioned this pull request Jan 30, 2018
Merged
timroes added a commit that referenced this pull request Jan 30, 2018
@timroes
[6.x] Fix issue with disabled lab mode (#16351) | Properly wait for s…
eceb08d 
…earch list to load (#16388) (#16394)

* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)
timroes added a commit that referenced this pull request Jan 30, 2018
@timroes
[6.2] Fix issue with disabled lab mode (#16351) (#16395)
2ff20dc 
* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)

* Apply patch for 6.2 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
blocker bug Fixes for quality problems that affect the customer experience release_note:fix v6.2.0 v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot load saved searches with lab modes disabled
4 participants
@timroes @elasticmachine @thomasneirynck @ppisljar